forked from OSchip/llvm-project
e4b4ab6d26
This patch changes the return type of sys::Process::getPageSize to Expected<unsigned> to account for the fact that the underlying syscalls used to obtain the page size may fail (see below). For clients who use the page size as an optimization only this patch adds a new method, getPageSizeEstimate, which calls through to getPageSize but discards any error returned and substitues a "reasonable" page size estimate estimate instead. All existing LLVM clients are updated to call getPageSizeEstimate rather than getPageSize. On Unix, sys::Process::getPageSize is implemented in terms of getpagesize or sysconf, depending on which macros are set. The sysconf call is documented to return -1 on failure. On Darwin getpagesize is implemented in terms of sysconf and may also fail (though the manpage documentation does not mention this). These failures have been observed in practice when highly restrictive sandbox permissions have been applied. Without this patch, the result is that getPageSize returns -1, which wreaks havoc on any subsequent code that was assuming a sane page size value. <rdar://problem/41654857> Reviewers: dblaikie, echristo Subscribers: kristina, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D59107 llvm-svn: 360221 |
||
|---|---|---|
| .. | ||
| IntelJITEvents | ||
| Interpreter | ||
| JITLink | ||
| MCJIT | ||
| OProfileJIT | ||
| Orc | ||
| PerfJITEvents | ||
| RuntimeDyld | ||
| CMakeLists.txt | ||
| ExecutionEngine.cpp | ||
| ExecutionEngineBindings.cpp | ||
| GDBRegistrationListener.cpp | ||
| LLVMBuild.txt | ||
| SectionMemoryManager.cpp | ||
| TargetSelect.cpp | ||