forked from OSchip/llvm-project
b989fcbae6
This can practically easily be a product of combining strings with macros in resource files. This fixes https://github.com/mstorsjo/llvm-mingw/issues/140. As string literals within llvm-rc are handled as StringRefs, each referencing an uninterpreted slice of the input file, with actual interpretation of the input string (codepage handling, unescaping etc) done only right before writing them out to disk, it's hard to concatenate them other than just bundling them up in a vector, without rearchitecting a large part of llvm-rc. This matches how the same already is supported in VersionInfoValue, with a std::vector<IntOrString> Values. MS rc.exe only supports concatenated string literals in version info values (already supported), string tables (implemented in this patch) and user data resources (easily implemented in a separate patch, but hasn't been requested by any end user yet), while GNU windres supports string immediates split into multiple strings anywhere (e.g. like (100 ICON "myicon" ".ico"). Not sure if concatenation in other statements actually is used in the wild though, in resource files normally built by GNU windres. Differential Revision: https://reviews.llvm.org/D85183 |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| LLVMBuild.txt | ||
| Opts.td | ||
| ResourceFileWriter.cpp | ||
| ResourceFileWriter.h | ||
| ResourceScriptCppFilter.cpp | ||
| ResourceScriptCppFilter.h | ||
| ResourceScriptParser.cpp | ||
| ResourceScriptParser.h | ||
| ResourceScriptStmt.cpp | ||
| ResourceScriptStmt.h | ||
| ResourceScriptToken.cpp | ||
| ResourceScriptToken.h | ||
| ResourceScriptTokenList.def | ||
| ResourceVisitor.h | ||
| llvm-rc.cpp | ||