llvm-project/lldb/source
Pavel Labath 553558292e [lldb/dyld-posix] Avoid reading the module list in inconsistent states
New glibc versions (since 2.34 or including this
<ed3ce71f5c>
patch) trigger the rendezvous breakpoint after they have already added
some modules to the list. This did not play well with our dynamic
loader plugin which was doing a diff of the the reported modules in the
before (RT_ADD) and after (RT_CONSISTENT) states. Specifically, it
caused us to miss some of the modules.

While I think the old behavior makes more sense, I don't think that lldb
is doing the right thing either, as the documentation states that we
should not be expecting a consistent view in the RT_ADD (and RT_DELETE)
states.

Therefore, this patch changes the lldb algorithm to compare the module
list against the previous consistent snapshot. This fixes the previous
issue, and I believe it is more correct in general. It also reduces the
number of times we are fetching the module info, which should speed up
the debugging of processes with many shared libraries.

The change in RefreshModules ensures we don't broadcast the loaded
notification for the dynamic loader (ld.so) module more than once.

Differential Revision: https://reviews.llvm.org/D128264
2022-07-01 08:08:22 +02:00
..
API Have CommandObjectParsed check for "commands that take no arguments". 2022-06-27 15:14:41 -07:00
Breakpoint [lld] Don't use Optional::hasValue (NFC) 2022-06-26 19:29:40 -07:00
Commands [trace] Make events first class items in the trace cursor and rework errors 2022-06-29 09:19:51 -07:00
Core [lld] Don't use Optional::hasValue (NFC) 2022-06-26 19:29:40 -07:00
DataFormatters [lldb] Add setting for max depth of value object printing (NFC) 2022-05-03 10:39:42 -07:00
Expression Support expressions in the context of a reference 2022-06-21 14:30:07 +02:00
Host [lldb] Add a log dump command 2022-06-27 10:02:34 -07:00
Initialization [lldb] Remove FileSystem::Initialize from FileCollector 2022-03-03 13:22:38 -08:00
Interpreter Have CommandObjectParsed check for "commands that take no arguments". 2022-06-27 15:14:41 -07:00
Plugins [lldb/dyld-posix] Avoid reading the module list in inconsistent states 2022-07-01 08:08:22 +02:00
Symbol [lldb] Replace Host::SystemLog with Debugger::Report{Error,Warning} 2022-06-24 09:46:26 -07:00
Target Threads which hit a breakpoint but fail the condition are considered 2022-06-30 11:43:59 -07:00
Utility [lldb] Add a log dump command 2022-06-27 10:02:34 -07:00
Version [lldb] Fix LLDB_FULL_VERSION_STRING 2022-01-19 14:20:22 -08:00
CMakeLists.txt [lldb] Make lldbVersion a full fledged library 2021-12-08 15:14:34 -08:00