forked from OSchip/llvm-project
b70fc0c5fd
More or less all the instructions defined in the v8.2a full-fp16 extension are defined as UNPREDICTABLE if you put them in an IT block (Thumb) or use with any condition other than AL (ARM). LLVM didn't know that, and was happy to conditionalise them. In order to force these instructions to count as not predicable, I had to make a small Tablegen change. The code generation back end mostly decides if an instruction was predicable by looking for something it can identify as a predicate operand; there's an isPredicable bit flag that overrides that check in the positive direction, but nothing that overrides it in the negative direction. (I considered the alternative approach of actually removing the predicate operand from those instructions, but thought that it would be more painful overall for instructions differing only in data type to have different shapes of operand list. This way, the only code that has to notice the difference is the if-converter.) So I've added an isUnpredicable bit alongside isPredicable, and set that bit on the right subset of FP16 instructions, and also on the VSEL, VMAXNM/VMINNM and VRINT[ANPM] families which should be unpredicable for all data types. I've included a couple of representative regression tests, both of which previously caused an fp16 instruction to be conditionalised in ARM state and (with -arm-no-restrict-it) to be put in an IT block in Thumb. Reviewers: SjoerdMeijer, t.p.northover, efriedma Reviewed By: efriedma Subscribers: jdoerfert, javed.absar, kristof.beyls, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D57823 llvm-svn: 354768 |
||
|---|---|---|
| .. | ||
| FileCheck | ||
| KillTheDoctor | ||
| LLVMVisualizers | ||
| Misc | ||
| PerfectShuffle | ||
| Reviewing | ||
| TableGen | ||
| Target/ARM | ||
| UpdateTestChecks | ||
| benchmark | ||
| bugpoint | ||
| count | ||
| crosstool | ||
| docker | ||
| emacs | ||
| fpcmp | ||
| gdb-scripts | ||
| git | ||
| git-svn | ||
| gn | ||
| jedit | ||
| kate | ||
| lint | ||
| lit | ||
| llvm-build | ||
| llvm-lit | ||
| not | ||
| release | ||
| sanitizers | ||
| testgen | ||
| textmate | ||
| unittest | ||
| valgrind | ||
| vim | ||
| vscode | ||
| yaml-bench | ||
| DSAclean.py | ||
| DSAextract.py | ||
| GenLibDeps.pl | ||
| GetRepositoryPath | ||
| GetSourceVersion | ||
| LLVMBuild.txt | ||
| UpdateCMakeLists.pl | ||
| abtest.py | ||
| bisect | ||
| bisect-skip-count | ||
| bugpoint_gisel_reducer.py | ||
| check-each-file | ||
| clang-parse-diagnostics-file | ||
| codegen-diff | ||
| collect_and_build_with_pgo.py | ||
| countloc.sh | ||
| create_ladder_graph.py | ||
| demangle_tree.py | ||
| extract_symbols.py | ||
| extract_vplan.py | ||
| findmisopt | ||
| findoptdiff | ||
| findsym.pl | ||
| getsrcs.sh | ||
| indirect_calls.py | ||
| lldbDataFormatters.py | ||
| llvm-compilers-check | ||
| llvm-gisel-cov.py | ||
| llvm-native-gxx | ||
| llvm.grm | ||
| llvmdo | ||
| llvmgrep | ||
| prepare-code-coverage-artifact.py | ||
| schedcover.py | ||
| shuffle_fuzz.py | ||
| shuffle_select_fuzz_tester.py | ||
| sort_includes.py | ||
| unicode-case-fold.py | ||
| update_analyze_test_checks.py | ||
| update_cc_test_checks.py | ||
| update_llc_test_checks.py | ||
| update_mca_test_checks.py | ||
| update_mir_test_checks.py | ||
| update_test_checks.py | ||
| wciia.py | ||