maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
311,563 Commits 23 Branches 0 Tags 2.2 GiB
C++ 39.1%
LLVM 35.7%
C 12.1%
Assembly 8.9%
Python 1.1%
Other 2.7%
Go to file
Nico Weber c3130a8a52 gn build: Unbreak finding a working `gn` on $PATH on Unix after r355645 
From the Python subprocess docs:

   If shell is True, it is recommended to pass args as a string rather than as
   a sequence.

   [...]

   If args is a sequence, the first item specifies the command string, and any
   additional items will be treated as additional arguments to the shell itself.

Prior to this change, the `--version` would be passed to the shell, not to
a potential gn binary on $PATH, and running `gn` without any arguments makes
it exit with an exit code != 0, so the script would think that there wasn't
a working gn binary on $PATH.

Fix this by following the documentation's recommendation of using a string
now that we pass shell=True. I tested this on macOS and Windows, each with
the three cases of

- no gn on PATH (should run gn downloaded by get.py if present,
  else suggest running get.py)
- broken gn wrapper on PATH (should behave like the previous item)
- working gn on PATH (should use gn on PATH)

llvm-svn: 355694
 		2019-03-08 13:01:58 +00:00
clang [IR][ARM] Add function pointer alignment to datalayout 2019-03-08 10:44:06 +00:00
clang-tools-extra [clangd] Remove ./ and ../ in the file paths 2019-03-08 09:57:33 +00:00
compiler-rt [sanitizer] Update global_symbols.txt 2019-03-08 12:41:42 +00:00
debuginfo-tests Set config.lit_tools_dir, which is needed by lit.llvm.initialize. 2018-11-06 21:54:27 +00:00
libclc Adjust documentation for git migration. 2019-01-29 16:37:27 +00:00
libcxx [runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/ 2019-03-08 05:35:22 +00:00
libcxxabi [runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/ 2019-03-08 05:35:22 +00:00
libunwind [runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/ 2019-03-08 05:35:22 +00:00
lld ELF: Reduce the size of InputSectionBase by two words. NFCI. 2019-03-07 18:48:12 +00:00
lldb Make function definition in header inline 2019-03-08 10:43:56 +00:00
llgo Adjust documentation for git migration. 2019-01-29 16:37:27 +00:00
llvm gn build: Unbreak finding a working `gn` on $PATH on Unix after r355645 2019-03-08 13:01:58 +00:00
openmp [mips] Use libatomic instead of GCC intrinsics for 64bit 2019-03-08 10:53:19 +00:00
parallel-libs Fix typos throughout the license files that somehow I and my reviewers 2019-01-21 09:52:34 +00:00
polly [opaque pointer types] Update calls to CreateCall to pass the function 2019-02-08 19:30:46 +00:00
pstl [pstl] Fix missing parallel policy guards 2019-03-01 01:26:35 +00:00
.arcconfig Update monorepo .arcconfig with new project callsign. 2019-01-31 14:34:59 +00:00
.clang-format Add .clang-tidy and .clang-format files to the toplevel of the 2019-01-29 16:43:16 +00:00
.clang-tidy Disable tidy checks with too many hits 2019-02-01 11:20:13 +00:00
README.md
…

README.md

The LLVM Compiler Infrastructure

This directory and its subdirectories contain source code for LLVM, a toolkit for the construction of highly optimized compilers, optimizers, and runtime environments.