Zachary Turner eb62999455 [PDB] Don't ignore bucket 0 when writing the PDB string table. ... The hash table is a list of buckets, and the *value* stored in the bucket cannot be 0 since that is reserved. However, the code here was incorrectly skipping over the 0'th bucket entirely. The 0'th bucket is perfectly fine, just none of these buckets can contain the value 0. As a result, whenever there was a string where hash(S) % Size was equal to 0, we would write the value in the next bucket instead. We never caught this in our tests due to *another* bug, which is that we would iterate the entire list of buckets looking for the value, only using the hash value as a starting point. However, the real algorithm stops when it finds 0 in a bucket since it takes that to mean "the item is not in the hash table". The unit test is updated to carefully construct a set of hash values that will cause one item to hash to 0 mod bucket count, and the reader is also updated to return an error indicating that the item is not found when it encounters a 0 bucket. llvm-svn: 328162		2018-03-21 22:23:59 +00:00
..
CodeView	Remove redundant includes from unittests.	2017-12-13 21:31:05 +00:00
DWARF	DWARF: Unify form size handling code	2018-03-14 09:39:54 +00:00
MSF	[MSF] Fix FPM interval calcluation	2018-01-05 18:12:14 +00:00
PDB	[PDB] Don't ignore bucket 0 when writing the PDB string table.	2018-03-21 22:23:59 +00:00
CMakeLists.txt	[MSF] Move MSF unit tests to their own unittest target.	2017-08-02 22:26:09 +00:00