llvm-project/clang/lib/CodeGen
Akira Hatanaka e9bf0a710c [CodeGen] Store the return value of the target function call to the
thunk's return value slot directly when the return type is an aggregate
instead of doing so via a temporary

This fixes PR45997 (https://bugs.llvm.org/show_bug.cgi?id=45997), which
is caused by a bug that has existed since we started passing and
returning C++ structs with ObjC strong pointer members (see
https://reviews.llvm.org/D44908) or structs annotated with trivial_abi
directly.

rdar://problem/63740936

Differential Revision: https://reviews.llvm.org/D82513
2020-07-10 17:24:13 -07:00
..
ABIInfo.h [clang] Re-add deleted forward declaration. 2020-07-02 08:57:48 +02:00
Address.h Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
BackendUtil.cpp [LPM] Port CGProfilePass from NPM to LPM 2020-07-10 09:04:51 -07:00
CGAtomic.cpp Clean up usages of asserting vector getters in Type 2020-04-13 13:01:40 -07:00
CGBlocks.cpp [CodeGen] Simplify the way lifetime of block captures is extended 2020-06-11 16:06:22 -07:00
CGBlocks.h [CodeGen] Simplify the way lifetime of block captures is extended 2020-06-11 16:06:22 -07:00
CGBuilder.h Reapply "[IRBuilder] Virtualize IRBuilder" 2020-02-17 19:04:11 +01:00
CGBuiltin.cpp orrectly generate invert xor value for Binary Atomics of int size > 64 2020-07-07 10:20:14 -07:00
CGCUDANV.cpp [cuda][hip] Fix `RegisterVar` function prototype. 2020-04-03 12:57:09 -04:00
CGCUDARuntime.cpp Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
CGCUDARuntime.h Fix GCC warning on enum class bitfield. NFC. 2020-03-28 10:20:34 -04:00
CGCXX.cpp [Alignment][NFC] Use Align with CreateAlignedLoad 2020-01-27 10:58:36 +01:00
CGCXXABI.cpp [CodeGen] Store the return value of the target function call to the 2020-07-10 17:24:13 -07:00
CGCXXABI.h [CodeGen] Add public function to emit C++ destructor call. 2020-07-01 11:01:23 -07:00
CGCall.cpp Change behavior with zero-sized static array extents 2020-07-10 15:58:11 -04:00
CGCall.h [CodeGen] Emit destructor calls to destruct non-trivial C struct objects 2020-03-20 18:34:22 -07:00
CGClass.cpp [clang/llvm] As part of using inclusive language within 2020-06-20 16:03:58 -07:00
CGCleanup.cpp [CodeGen] Simplify the way lifetime of block captures is extended 2020-06-11 16:06:22 -07:00
CGCleanup.h Remove clang::Codegen::EHPadEndScope as unused 2020-06-23 15:18:49 -07:00
CGCoroutine.cpp [Coroutines] Do not evaluate InitListExpr of a co_return 2020-03-16 12:42:44 +08:00
CGDebugInfo.cpp Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t 2020-06-11 09:12:29 +01:00
CGDebugInfo.h Reland (again) D80966 [codeview] Put !heapallocsite on calls to operator new 2020-06-09 09:27:32 -07:00
CGDecl.cpp [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder. 2020-07-08 17:23:55 +02:00
CGDeclCXX.cpp [AIX][Frontend] Static init implementation for AIX considering no priority 2020-06-19 08:27:07 -04:00
CGException.cpp Remove clang::Codegen::EHPadEndScope as unused 2020-06-23 15:18:49 -07:00
CGExpr.cpp [OPENMP50] extend array section for stride (Parsing/Sema/AST) 2020-07-09 13:28:51 -05:00
CGExprAgg.cpp attempt to fix failing buildbots after 3bab88b7ba 2020-06-15 12:58:37 +02:00
CGExprCXX.cpp Change debuginfo check for addHeapAllocSiteMetadata 2020-06-09 11:01:06 -07:00
CGExprComplex.cpp [clang][NFC] Store a pointer to the ASTContext in ASTDumper and TextNodeDumper 2020-07-03 13:59:22 +01:00
CGExprConstant.cpp [c++20] consteval functions don't get vtable slots. 2020-06-30 18:22:09 -07:00
CGExprScalar.cpp [clang][NFC] Store a pointer to the ASTContext in ASTDumper and TextNodeDumper 2020-07-03 13:59:22 +01:00
CGGPUBuiltin.cpp [Alignment][NFC] Use Align with CreateAlignedStore 2020-01-23 17:34:32 +01:00
CGLoopInfo.cpp [Clang] Add llvm.loop.unroll.disable to loops with -fno-unroll-loops. 2020-04-07 14:01:55 +01:00
CGLoopInfo.h [Clang] Add llvm.loop.unroll.disable to loops with -fno-unroll-loops. 2020-04-07 14:01:55 +01:00
CGNonTrivialStruct.cpp [NFC] Silence compiler warning [-Wmissing-braces]. 2020-06-17 13:01:53 -07:00
CGObjC.cpp Reland D81869 "Modify FPFeatures to use delta not absolute settings" 2020-06-27 01:34:57 -07:00
CGObjCGNU.cpp [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec. 2020-04-23 17:21:25 -04:00
CGObjCMac.cpp [ADT/STLExtras.h] - Add llvm::is_sorted wrapper and update callers. 2020-04-14 14:11:02 +03:00
CGObjCRuntime.cpp [clang] CodeGen: Make getOrEmitProtocol public for Swift 2020-04-01 08:55:56 -07:00
CGObjCRuntime.h [clang] CodeGen: Make getOrEmitProtocol public for Swift 2020-04-01 08:55:56 -07:00
CGOpenCLRuntime.cpp Fix "pointer is null" static analyzer warning. NFCI. 2020-01-08 17:19:08 +00:00
CGOpenCLRuntime.h [OpenCL] Simplify LLVM IR generated for OpenCL blocks 2019-02-21 11:02:10 +00:00
CGOpenMPRuntime.cpp [OPENMP50] extend array section for stride (Parsing/Sema/AST) 2020-07-09 13:28:51 -05:00
CGOpenMPRuntime.h [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder. 2020-07-08 17:23:55 +02:00
CGOpenMPRuntimeNVPTX.cpp [flang][openmp] Use common Directive and Clause enum from llvm/Frontend 2020-07-01 20:58:11 -04:00
CGOpenMPRuntimeNVPTX.h [OpenMP] `omp begin/end declare variant` - part 2, sema ("+CG") 2020-03-27 02:30:58 -05:00
CGRecordLayout.h Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
CGRecordLayoutBuilder.cpp [CodeGen] Increase applicability of ffine-grained-bitfield-accesses for targets with limited native integer widths 2020-06-12 10:33:47 +01:00
CGStmt.cpp attempt to fix failing buildbots after 3bab88b7ba 2020-06-15 12:58:37 +02:00
CGStmtOpenMP.cpp [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder. 2020-07-08 17:23:55 +02:00
CGVTT.cpp Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
CGVTables.cpp [CodeGen] Store the return value of the target function call to the 2020-07-10 17:24:13 -07:00
CGVTables.h [clang] Frontend components for the relative vtables ABI (round 2) 2020-06-11 11:17:08 -07:00
CGValue.h [Matrix] Implement matrix index expressions ([][]). 2020-06-01 20:08:49 +01:00
CMakeLists.txt Update compiler extension integration into the build system 2020-04-24 09:40:14 +02:00
CodeGenABITypes.cpp [CodeGen] Add public function to emit C++ destructor call. 2020-07-01 11:01:23 -07:00
CodeGenAction.cpp Expose IRGen API to add the default IR attributes to a function definition. 2020-05-16 14:44:54 -04:00
CodeGenFunction.cpp [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder. 2020-07-08 17:23:55 +02:00
CodeGenFunction.h [Coroutines] Warning if return type of coroutine_handle::address is not void* 2020-07-06 13:46:01 +08:00
CodeGenModule.cpp [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder. 2020-07-08 17:23:55 +02:00
CodeGenModule.h [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder. 2020-07-08 17:23:55 +02:00
CodeGenPGO.cpp [PGO] Fix computation of function Hash 2020-05-27 09:15:21 +02:00
CodeGenPGO.h [CodeGenPGO] Fix shadow variable warning. NFC. 2020-03-02 15:06:34 +00:00
CodeGenTBAA.cpp Reland Implement _ExtInt as an extended int type specifier. 2020-04-17 10:45:48 -07:00
CodeGenTBAA.h Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
CodeGenTypeCache.h [ARM] Add __bf16 as new Bfloat16 C Type 2020-06-05 10:32:43 +01:00
CodeGenTypes.cpp [AArch64][SVE] ACLE: Add bfloat16 to struct load/stores. 2020-06-23 12:12:35 +01:00
CodeGenTypes.h CodeGenTypes::CGRecordLayouts: Use unique_ptr to simplify memory management 2020-04-28 22:31:16 -07:00
ConstantEmitter.h attempt to fix failing buildbots after 3bab88b7ba 2020-06-15 12:58:37 +02:00
ConstantInitBuilder.cpp Fix ConstantAggregateBuilderBase::getRelativeOffset 2020-06-15 12:23:20 -07:00
CoverageMappingGen.cpp [Coroutines] Fix code coverage for coroutine 2020-07-01 10:11:40 -07:00
CoverageMappingGen.h Reland: [Coverage] Revise format to reduce binary size 2020-02-28 18:12:04 -08:00
EHScopeStack.h [CodeGen] Simplify the way lifetime of block captures is extended 2020-06-11 16:06:22 -07:00
ItaniumCXXABI.cpp [CodeGen] Add public function to emit C++ destructor call. 2020-07-01 11:01:23 -07:00
MacroPPCallbacks.cpp Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
MacroPPCallbacks.h Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
MicrosoftCXXABI.cpp [CodeGen] Add public function to emit C++ destructor call. 2020-07-01 11:01:23 -07:00
ModuleBuilder.cpp reland "[DebugInfo] Support to emit debugInfo for extern variables" 2019-12-22 18:28:50 -08:00
ObjectFilePCHContainerOperations.cpp Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t 2020-06-11 09:12:29 +01:00
PatternInit.cpp Clean up usages of asserting vector getters in Type 2020-04-13 13:01:40 -07:00
PatternInit.h Variable auto-init: also auto-init alloca 2019-04-12 00:11:27 +00:00
README.txt
SanitizerMetadata.cpp [Analysis/Transforms/Sanitizers] As part of using inclusive language 2020-06-20 00:42:26 -07:00
SanitizerMetadata.h [Analysis/Transforms/Sanitizers] As part of using inclusive language 2020-06-20 00:42:26 -07:00
SwiftCallingConv.cpp [SVE] Eliminate calls to default-false VectorType::get() from Clang 2020-06-01 10:02:14 -07:00
TargetInfo.cpp [ABI] Handle C++20 [[no_unique_address]] attribute 2020-07-10 14:01:05 +02:00
TargetInfo.h Implement AVX ABI Warning/error 2020-07-01 07:14:31 -07:00
VarBypassDetector.cpp Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
VarBypassDetector.h Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00

README.txt

IRgen optimization opportunities.

//===---------------------------------------------------------------------===//

The common pattern of
--
short x; // or char, etc
(x == 10)
--
generates an zext/sext of x which can easily be avoided.

//===---------------------------------------------------------------------===//

Bitfields accesses can be shifted to simplify masking and sign
extension. For example, if the bitfield width is 8 and it is
appropriately aligned then is is a lot shorter to just load the char
directly.

//===---------------------------------------------------------------------===//

It may be worth avoiding creation of alloca's for formal arguments
for the common situation where the argument is never written to or has
its address taken. The idea would be to begin generating code by using
the argument directly and if its address is taken or it is stored to
then generate the alloca and patch up the existing code.

In theory, the same optimization could be a win for block local
variables as long as the declaration dominates all statements in the
block.

NOTE: The main case we care about this for is for -O0 -g compile time
performance, and in that scenario we will need to emit the alloca
anyway currently to emit proper debug info. So this is blocked by
being able to emit debug information which refers to an LLVM
temporary, not an alloca.

//===---------------------------------------------------------------------===//

We should try and avoid generating basic blocks which only contain
jumps. At -O0, this penalizes us all the way from IRgen (malloc &
instruction overhead), all the way down through code generation and
assembly time.

On 176.gcc:expr.ll, it looks like over 12% of basic blocks are just
direct branches!

//===---------------------------------------------------------------------===//