maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/mlir
History
Sean Silva b277382311 Remove error-prone mlir::ExecutionEngine::invoke overload. 
I just spent a bunch of time debugging a mysterious bug that ended being due to my SmallVector getting passed to the Args&... overload instead of the MutableArrayRef overload, with disastrous results.

I appreciate the intent of this API, but for a function that does a bunch of unsafe casts, adding in potential overload confusion is just too much C++ footgun. If we end up needing this functionality, having something like a separate `packArgs(Args&...) -> SmallVector` overload would be preferable.

Turns out this API is unused and untested (even out of tree as far as I can tell, modulo the optional passing of no args to the other invoke as I fixed in this patch), so it's an easy fix -- just delete it and touch up the other overload.

Differential Revision: https://reviews.llvm.org/D80607
 		2020-05-27 13:26:03 -07:00
..
cmake/modules [MLIR][cmake][NFC] Check for incorrect usage of LLVM components in LINK_LIBS 2020-05-19 14:50:54 -07:00
docs [mlir] Add simple generator for return types 2020-05-27 08:45:55 -07:00
examples [mlir] Erase or clear blocks through ConversionPatternRewriter when applicable 2020-05-20 16:12:05 +02:00
include Remove error-prone mlir::ExecutionEngine::invoke overload. 2020-05-27 13:26:03 -07:00
lib [mlir][Linalg] Fix build failure from D80188 2020-05-27 13:06:43 -07:00
test [mlir] [VectorOps] Add 'vector.flat_transpose' operation 2020-05-27 11:09:48 -07:00
tools [mlir] Add simple generator for return types 2020-05-27 08:45:55 -07:00
unittests [MLIR] LLVMMLIRTableGen -> MLIRTableGen 2020-05-19 14:49:32 -07:00
utils [mlir] Change generate-test-checks.py to `%[[V:.*]]` style 2020-05-13 14:50:14 -07:00
.clang-format
…
.clang-tidy Fix MLIR clang-tidy: when tweaking it does not inherit from the parent 2020-03-07 17:44:21 +00:00
CMakeLists.txt [MLIR] Use `MLIR_INCLUDE_TESTS` to conditionally compile tests. 2020-05-18 18:47:37 +02:00
LICENSE.TXT Add the Apache2 with LLVM exceptions license to MLIR 2019-12-24 00:58:06 -08:00
README.md mlir README.md: Fix the syntax 2019-12-24 13:31:07 +01:00

README.md

Multi-Level Intermediate Representation

See https://mlir.llvm.org/ for more information.