Raphael Isemann 24e07570cc [lldb] Remove all the RegisterInfo name constification code ... RegisterInfo's `reg_name`/`reg_alt_name` fields are C-Strings and are supposed to only be generated from a ConstString. The reason for that is that `DynamicRegisterInfo::GetRegisterInfo` and `RegInfoBasedABI::GetRegisterInfoByName` try to optimise finding registers by name by only comparing the C string pointer values instead of the underlying strings. This only works if both C strings involved in the comparison come from a ConstString. If one of the two C strings doesn't come from a ConstString the comparison won't work (and most likely will silently fail). I added an assert in b0060c3a78 which checks that both strings come from a ConstString. Apparently not all ABI plugins are generating their register names via ConstString, so this code is now not just silently failing but also asserting. In D88375 we did a shady fix for the MIPS plugins by just copying the ConstString setup code to that plugin, but we still need to fix ABISysV_arc, ABISysV_ppc and ABISysV_ppc64 plugins. I would say we just fix the remaining plugins by removing the whole requirement to have the register names coming from ConstStrings. I really doubt that we actually save any time with the whole ConstString search trick (searching ~50 strings that have <4 characters doesn't sound more expensive than calling the really expensive ConstString constructor + comparing the same amount of pointer values). Also whatever small percentage of LLDB's runtime is actually spend in this function is anyway not worth the complexity of this approach. This patch just removes all this and just does a normal string comparison. Reviewed By: JDevlieghere, labath Differential Revision: https://reviews.llvm.org/D88490		2020-10-13 17:10:29 +02:00
..
ABIMips.cpp	[lldb/Plugin] s/LLDB_PLUGIN/LLDB_PLUGIN_DEFINE/ (NFC)	2020-02-14 09:58:24 -08:00
ABIMips.h	[lldb] Update header guards to be consistent and compliant with LLVM (NFC)	2020-02-17 23:15:40 -08:00
ABISysV_mips.cpp	[lldb] Remove all the RegisterInfo name constification code	2020-10-13 17:10:29 +02:00
ABISysV_mips.h	[lldb] Update header guards to be consistent and compliant with LLVM (NFC)	2020-02-17 23:15:40 -08:00
ABISysV_mips64.cpp	[lldb] Remove all the RegisterInfo name constification code	2020-10-13 17:10:29 +02:00
ABISysV_mips64.h	As part of using inclusive language with the llvm project,	2020-06-19 14:48:48 -07:00
CMakeLists.txt	[lldb/Plugins] Have one initializer per ABI plugin	2020-02-13 21:49:38 -08:00