Jaroslav Sevcik 1beffc1888 Support build-ids of other sizes than 16 in UUID::SetFromStringRef ... SBTarget::AddModule currently handles the UUID parameter in a very weird way: UUIDs with more than 16 bytes are trimmed to 16 bytes. On the other hand, shorter-than-16-bytes UUIDs are completely ignored. In this patch, we change the parsing code to handle UUIDs of arbitrary size. To support arbitrary size UUIDs in SBTarget::AddModule, this patch changes UUID::SetFromStringRef to parse UUIDs of arbitrary length. We subtly change the semantics of SetFromStringRef - SetFromStringRef now only succeeds if the entire input is consumed to prevent some prefix-parsing confusion. This is up for discussion, but I believe this is more consistent - we always return false for invalid UUIDs rather than sometimes truncating to a valid prefix. Also, all the call-sites except the API and interpreter seem to expect to consume the entire input. This also adds tests for adding existing modules 4-, 16-, and 20-byte build-ids. Finally, we took the liberty of testing the minidump scenario we care about - removing placeholder module from minidump and replacing it with the real module. Reviewed By: labath, friss Differential Revision: https://reviews.llvm.org/D80755		2020-06-07 10:03:41 +00:00
..
CMakeLists.txt	[lldb/CMake] Fix variable naming in FindLibEdit	2020-01-02 13:39:57 -08:00
CommandAlias.cpp	[LLDB] Fix compilation with GCC 5	2020-02-06 10:16:32 +02:00
CommandHistory.cpp	Make llvm::StringRef to std::string conversions explicit.	2020-01-28 23:25:25 +01:00
CommandInterpreter.cpp	Be more specific about auto * vs auto for po alias.	2020-05-26 11:59:09 -07:00
CommandObject.cpp	[lldb] Tab completion for process plugin name	2020-05-27 14:11:16 +02:00
CommandObjectRegexCommand.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
CommandObjectScript.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
CommandObjectScript.h	[lldb] Update header guards to be consistent and compliant with LLVM (NFC)	2020-02-17 23:15:40 -08:00
CommandOptionValidators.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
CommandReturnObject.cpp	[lldb/Interpreter] Remove redundant argument (NFC)	2020-06-02 21:23:19 -07:00
InterpreterProperties.td	[lldb] Qualify includes of Properties[Enum].inc files. NFC	2019-07-29 17:22:10 +00:00
OptionArgParser.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionGroupArchitecture.cpp	Make llvm::StringRef to std::string conversions explicit.	2020-01-28 23:25:25 +01:00
OptionGroupBoolean.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionGroupFile.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionGroupFormat.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionGroupOutputFile.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionGroupPlatform.cpp	Make llvm::StringRef to std::string conversions explicit.	2020-01-28 23:25:25 +01:00
OptionGroupPythonClassWithDict.cpp	Make llvm::StringRef to std::string conversions explicit.	2020-01-28 23:25:25 +01:00
OptionGroupString.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionGroupUInt64.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionGroupUUID.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionGroupValueObjectDisplay.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionGroupVariable.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionGroupWatchpoint.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionValue.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionValueArch.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionValueArgs.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionValueArray.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionValueBoolean.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionValueChar.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionValueDictionary.cpp	[lldb][NFC] Remove ConstString -> const char * -> StringRef conversions when calling Stream::Indent	2020-02-11 13:51:41 +01:00
OptionValueEnumeration.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionValueFileSpec.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionValueFileSpecList.cpp	[lldb][NFC] Migrate FileSpec::Dump to raw_ostream	2019-12-06 09:40:42 +01:00
OptionValueFormat.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionValueFormatEntity.cpp	Make llvm::StringRef to std::string conversions explicit.	2020-01-28 23:25:25 +01:00
OptionValueLanguage.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionValuePathMappings.cpp	[source maps] Fix remove, insert-after and replace	2020-04-03 19:15:56 -07:00
OptionValueProperties.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionValueRegex.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionValueSInt64.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionValueString.cpp	Make llvm::StringRef to std::string conversions explicit.	2020-01-28 23:25:25 +01:00
OptionValueUInt64.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
OptionValueUUID.cpp	Support build-ids of other sizes than 16 in UUID::SetFromStringRef	2020-06-07 10:03:41 +00:00
Options.cpp	[lldb][NFC] Remove ConstString -> const char * -> StringRef conversions when calling Stream::Indent	2020-02-11 13:51:41 +01:00
Property.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
ScriptInterpreter.cpp	[lldb][NFC] Fix all formatting errors in .cpp file headers	2020-01-24 08:52:55 +01:00
embedded_interpreter.py	[Python] Flush prompt before reading input	2019-06-25 17:27:38 +00:00