llvm-project/lldb
Pavel Labath b07a799752 DWARFExpression: Fix implementation of DW_OP_pick
Summary:
The DWARF spec states that the DWARF stack arguments are numbered from
the top. Our implementation of DW_OP_pick was counting them from the
bottom.

This bug probably wasn't noticed because nobody (except my upcoming
postfix-to-DWARF converter) uses DW_OP_pick, but I've cross-checked with
gdb to confirm that counting from the top is the expected behavior.

This patch fixes the implementation to match the spec and gdb behavior
and adds a test.

Reviewers: jasonmolenda, clayborg

Subscribers: mgorny, aprantl, lldb-commits

Differential Revision: https://reviews.llvm.org/D61182

llvm-svn: 359436
2019-04-29 10:55:22 +00:00
..
cmake [CMake] Remove Apple-specific version logic. 2019-04-17 18:23:22 +00:00
docs [Docs] Add more redirects 2019-04-24 01:58:17 +00:00
examples [Python] Simplify the code. NFCI. 2019-04-18 23:24:54 +00:00
include/lldb DWARFExpression: Fix implementation of DW_OP_pick 2019-04-29 10:55:22 +00:00
lit [Windows] Dump more information about access violation exception 2019-04-29 07:29:25 +00:00
lldb.xcodeproj add postfixexpression.cpp. 2019-04-24 19:50:53 +00:00
lldb.xcworkspace Remove accidentally commited file in xcshareddata 2019-02-05 23:35:01 +00:00
packages/Python/lldbsuite [Windows] Dump more information about access violation exception 2019-04-29 07:29:25 +00:00
resources [CMake] Revised LLDB.framework builds 2019-01-04 12:46:50 +00:00
scripts Kill modify-python-lldb.py 2019-04-24 13:23:19 +00:00
source DWARFExpression: Fix implementation of DW_OP_pick 2019-04-29 10:55:22 +00:00
test [CMake] Make lldb-test-deps a dependency of check-lldb 2019-02-13 20:51:13 +00:00
third_party/Python/module [lldb/thirdparty] Remove unneeded files, asked by Jonas. 2019-03-12 20:41:36 +00:00
tools [Driver] Remove unused functions (NFC) 2019-04-26 22:54:39 +00:00
unittests DWARFExpression: Fix implementation of DW_OP_pick 2019-04-29 10:55:22 +00:00
utils [lldb] [lit] Add register read tests for YMM registers (AVX) 2019-04-26 13:21:58 +00:00
www Don't abort() in lldb_assert and document why. 2019-03-29 16:12:27 +00:00
.arcconfig
.clang-format
.gitignore Add .noindex to the gitignore 2019-04-05 17:57:42 +00:00
CMakeLists.txt [lldb] [lit] Add feature flags for native CPU features 2019-04-26 13:21:46 +00:00
CODE_OWNERS.txt Fix/unify the spelling of Objective-C. 2018-06-13 16:21:24 +00:00
INSTALL.txt Changed builld-llvm.py to use .json files 2017-02-23 02:21:34 +00:00
LICENSE.TXT Fix typos throughout the license files that somehow I and my reviewers 2019-01-21 09:52:34 +00:00
use_lldb_suite_root.py