llvm-project/clang-tools-extra/test/clang-tidy/checkers/readability-use-anyofallof.cpp

184 lines
3.2 KiB
C++

// RUN: %check_clang_tidy -std=c++14,c++17 %s readability-use-anyofallof %t -- -- -fexceptions
bool good_any_of() {
int v[] = {1, 2, 3};
// CHECK-MESSAGES: :[[@LINE+1]]:3: warning: replace loop by 'std::any_of()' [readability-use-anyofallof]
for (int i : v)
if (i)
return true;
return false;
}
bool cond(int i);
bool good_any_of2() {
int v[] = {1, 2, 3};
for (int i : v) {
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: replace loop by 'std::any_of()'
int k = i / 2;
if (cond(k))
return true;
}
return false;
}
bool good_any_of3() {
int v[] = {1, 2, 3};
for (int i : v) {
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: replace loop by 'std::any_of()'
if (i == 3)
continue;
if (i)
return true;
}
return false;
}
bool good_any_of_use_external(int comp) {
int v[] = {1, 2, 3};
for (int i : v) {
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: replace loop by 'std::any_of()'
if (i == comp)
return true;
}
return false;
}
bool good_any_of_no_cond() {
int v[] = {1, 2, 3};
for (int i : v) {
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: replace loop by 'std::any_of()'
return true; // Not a real loop, but technically can become any_of.
}
return false;
}
bool good_any_of_local_modification() {
int v[] = {1, 2, 3};
for (int i : v) {
int j = i;
j++; // FIXME: Any non-const use disables check.
if (j > 3)
return true;
}
return false;
}
bool good_any_of_throw() {
int v[] = {1, 2, 3};
for (int i : v) {
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: replace loop by 'std::any_of()'
if (i > 3)
return true;
if (i == 42)
throw 0;
}
return false;
}
bool bad_any_of1() {
int v[] = {1, 2, 3};
for (int i : v) {
if (i)
return false; // bad constant
}
return false;
}
bool bad_any_of2() {
int v[] = {1, 2, 3};
for (int i : v)
if (i)
return true;
return true; // bad return
}
bool bad_any_of3() {
int v[] = {1, 2, 3};
for (int i : v)
if (i)
return true;
else
return i / 2; // bad return
return false;
}
bool bad_any_of_control_flow1() {
int v[] = {1, 2, 3};
for (int i : v) {
break; // bad control flow
if (i)
return true;
}
return false;
}
bool bad_any_of_control_flow2() {
int v[] = {1, 2, 3};
for (int i : v) {
goto end; // bad control flow
if (i)
return true;
}
end:
return false;
}
bool bad_any_of4() {
return false; // wrong order
int v[] = {1, 2, 3};
for (int i : v) {
if (i)
return true;
}
}
bool bad_any_of5() {
int v[] = {1, 2, 3};
int j = 0;
for (int i : v) {
j++; // modifications
if (i)
return true;
}
return false;
}
bool bad_any_of6() {
int v[] = {1, 2, 3};
for (int i : v) {
if (i)
return true;
}
int j = 0; // Statements between loop and return
j++;
return false;
}
bool bad_any_of7() {
int v[] = {1, 2, 3};
for (int i : v) {
i; // No 'return true' in body.
}
return false;
}
bool good_all_of() {
int v[] = {1, 2, 3};
// CHECK-MESSAGES: :[[@LINE+1]]:3: warning: replace loop by 'std::all_of()' [readability-use-anyofallof]
for (int i : v)
if (i)
return false;
return true;
}