llvm-project/libcxx
JF Bastien 766128e697 Filesystem tests: un-confuse write time
Summary:
The filesystem test was confused about access versus write / modification time. The spec says:

  file_time_type last_write_time(const path& p, error_code& ec) noexcept;
  Returns: The time of last data modification of p, determined as if by the value of the POSIX stat structure member st_mtime obtained as if by POSIX stat(). The signature with argument ec returns file_time_type::min() if an error occurs.

The test was looking at st_atime, not st_mtime, when comparing the result from last_write_time. That was probably due to using a pair instead of naming things nicely or using types. I opted to rename things so it's clearer.

This used to cause test bot failures.

<rdar://problem/40648859>

Reviewers: EricWF, mclow.lists, aemerson

Subscribers: christof, cfe-commits

Differential Revision: https://reviews.llvm.org/D47557

llvm-svn: 333723
2018-06-01 04:59:48 +00:00
..
benchmarks Implement filesystem NB comments, relative paths, and related issues. 2018-04-02 23:03:41 +00:00
cmake Revert "[CMake] Use custom command and target to install libc++ headers" 2018-04-09 04:36:04 +00:00
docs Fix typos. 2018-02-13 08:12:00 +00:00
fuzzing Wrote my own version of is_permutation; that was dominating the timings 2018-01-19 03:17:45 +00:00
include Mark __clear_and_shrink() as noexcept. This prevents the generation of a catch block and call to terminate in string's move assignment. Thanks to Howard for the 'catch'. 2018-05-29 17:04:37 +00:00
lib Update ABI lists after change in r333467. 2018-05-29 23:52:14 +00:00
src Fix embarrasing typo in uncaught_exceptions. Update tests to really test this. Thanks to Peter Klotz for calling my attention to this. 2018-05-29 22:25:42 +00:00
test Filesystem tests: un-confuse write time 2018-06-01 04:59:48 +00:00
utils Avoid Clang error about throwing _LIBCPP_ASSERT in noexcept function. 2018-03-22 23:01:08 +00:00
www Mark more bits of P0433 as complete. 2018-05-23 03:22:59 +00:00
.arcconfig [libcxx] Set up .arcconfig to point to new Diffusion CXX repository 2017-12-04 17:55:28 +00:00
.clang-format Make clang-format use C++03 syntax 2017-04-15 02:45:43 +00:00
.gitignore Implement N4606 optional 2016-10-12 07:46:20 +00:00
CMakeLists.txt [CMake] Set the default ABI version for Fuchsia in CMake as well 2018-04-13 01:59:15 +00:00
CREDITS.TXT Try again, this time with the correct address 2017-12-29 19:26:53 +00:00
LICENSE.TXT Update year to 2017 2017-01-03 11:20:43 +00:00
NOTES.TXT Revert "[CMake] Use custom command and target to install libc++ headers" 2018-04-09 04:36:04 +00:00
TODO.TXT Add list of filesystem NB comments to TODO.TXT so they can be tracked separately 2017-03-06 21:23:36 +00:00
appveyor-reqs-install.cmd Update Clang version on Appveyor bots 2018-04-04 04:33:09 +00:00
appveyor.yml Rename Appveyor install helper script. 2017-05-10 02:43:02 +00:00