forked from OSchip/llvm-project
b3faa01ff9
Summary: IOHandler needs to read lines of input from a lldb::File. The way it currently does this using, FILE*, which is something we want to avoid now. I'd prefer to just replace the FILE* code with calls to File::Read, but it contains an awkward and delicate workaround specific to ctrl-C handling on windows, and it's not clear if or how that workaround would translate to lldb::File. So in this patch, we use use the FILE* if it's available, and only fall back on File::Read if that's the only option. I think this is a reasonable approach here for two reasons. First is that interactive terminal support is the one area where FILE* can't be avoided. We need them for libedit and curses anyway, and using them here as well is consistent with that pattern. The second reason is that the comments express a hope that the underlying windows bug that's being worked around will be fixed one day, so hopefully when that happens, that whole path can be deleted. Reviewers: JDevlieghere, jasonmolenda, labath, lanza Reviewed By: labath Subscribers: lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D68622 llvm-svn: 374576 |
||
|---|---|---|
| .. | ||
| API | ||
| Breakpoint | ||
| Core | ||
| DataFormatters | ||
| Expression | ||
| Host | ||
| Initialization | ||
| Interpreter | ||
| Symbol | ||
| Target | ||
| Utility | ||
| lldb-defines.h | ||
| lldb-enumerations.h | ||
| lldb-forward.h | ||
| lldb-private-defines.h | ||
| lldb-private-enumerations.h | ||
| lldb-private-forward.h | ||
| lldb-private-interfaces.h | ||
| lldb-private-types.h | ||
| lldb-private.h | ||
| lldb-public.h | ||
| lldb-types.h | ||
| lldb-versioning.h | ||
| module.modulemap | ||