llvm-project/llvm/lib/Target/WebAssembly
Paulo Matos c67c9cfe3f [WebAssembly] Refactor and fix emission of external IR global decls
Reland of 00bf4755.

This patches fixes the visibility and linkage information of symbols
referring to IR globals.

Emission of external declarations is now done in the first execution
of emitConstantPool rather than in emitLinkage (and a few other
places). This is the point where we have already gathered information
about used symbols (by running the MC Lower PrePass) and not yet
started emitting any functions so that any declarations that need to
be emitted are done so at the top of the file before any functions.

This changes the order of a few directives in the final asm file which
required an update to a few tests.

Reviewed By: sbc100

Differential Revision: https://reviews.llvm.org/D118995
2022-02-04 22:01:46 +01:00
..
AsmParser [WebAssembly] Fix typechecking for else MCInst 2021-12-16 11:18:01 +01:00
Disassembler [WebAssembly] Implementation of intrinsic for ref.null and HeapType removal 2021-12-06 09:46:15 +01:00
MCTargetDesc [Target] Remove unused forward declarations (NFC) 2022-01-02 10:20:15 -08:00
TargetInfo Fix shlib builds for all lib/Target/*/TargetInfo libs 2021-10-08 15:21:13 -07:00
Utils [WebAssembly][NFC] Refactor WasmSymbol type setting code 2022-01-29 09:00:51 +01:00
CMakeLists.txt Reland: "[WebAssembly] Add new pass to lower int/ptr conversions of reftypes" 2021-08-03 09:20:51 +02:00
README.txt [NFC] Inclusive language: Remove instances of master in URLs 2021-11-05 08:48:41 -05:00
WebAssembly.h [WebAssembly] Change WebAssemblyMCLowerPrePass to ModulePass 2021-09-08 10:47:43 -07:00
WebAssembly.td [WebAssembly] Add relaxed-simd feature 2021-09-22 14:52:50 -07:00
WebAssemblyAddMissingPrototypes.cpp [WebAssembly] Support opaque pointers in AddMissingPrototypes 2021-09-04 11:25:42 +02:00
WebAssemblyArgumentMove.cpp
WebAssemblyAsmPrinter.cpp [WebAssembly] Refactor and fix emission of external IR global decls 2022-02-04 22:01:46 +01:00
WebAssemblyAsmPrinter.h [WebAssembly] Refactor and fix emission of external IR global decls 2022-02-04 22:01:46 +01:00
WebAssemblyCFGSort.cpp
WebAssemblyCFGStackify.cpp [NFC] Rename MachineFunction::DeleteMachineBasicBlock 2021-12-08 18:12:51 -08:00
WebAssemblyDebugFixup.cpp
WebAssemblyDebugValueManager.cpp
WebAssemblyDebugValueManager.h
WebAssemblyExceptionInfo.cpp
WebAssemblyExceptionInfo.h
WebAssemblyExplicitLocals.cpp [NFC] Use Register instead of unsigned 2022-01-19 20:17:04 +08:00
WebAssemblyFastISel.cpp [WebAssembly][NFC] Refactor WasmSymbol type setting code 2022-01-29 09:00:51 +01:00
WebAssemblyFixBrTableDefaults.cpp [WebAssembly] Fix fixBrTableIndex removing instruction without checking uses 2021-11-08 15:53:44 -08:00
WebAssemblyFixFunctionBitcasts.cpp [WebAssembly] Support opaque pointers in FixFunctionBitcasts 2021-09-01 22:17:24 +02:00
WebAssemblyFixIrreducibleControlFlow.cpp
WebAssemblyFrameLowering.cpp [WebAssembly][NFC] Refactor WasmSymbol type setting code 2022-01-29 09:00:51 +01:00
WebAssemblyFrameLowering.h
WebAssemblyISD.def [WebAssembly] Custom optimization for truncate 2021-12-14 08:42:39 -08:00
WebAssemblyISelDAGToDAG.cpp [WebAssembly] Remove unused declaration SelectExternRefAddr (NFC) 2021-11-06 19:31:22 -07:00
WebAssemblyISelLowering.cpp [NFC] Use Register instead of unsigned 2022-01-19 20:17:04 +08:00
WebAssemblyISelLowering.h [WebAssembly] Implementation of table.get/set for reftypes in LLVM IR 2021-10-20 10:31:31 +02:00
WebAssemblyInstrAtomics.td [WebAssembly] NFC: Remove unused tblgen template args 2021-09-14 08:26:15 +00:00
WebAssemblyInstrBulkMemory.td
WebAssemblyInstrCall.td
WebAssemblyInstrControl.td [WebAssembly] Make result of 'catch' inst variadic 2021-08-04 14:05:33 -07:00
WebAssemblyInstrConv.td
WebAssemblyInstrFloat.td
WebAssemblyInstrFormats.td
WebAssemblyInstrInfo.cpp
WebAssemblyInstrInfo.h
WebAssemblyInstrInfo.td [WebAssembly] Implementation of intrinsic for ref.null and HeapType removal 2021-12-06 09:46:15 +01:00
WebAssemblyInstrInteger.td
WebAssemblyInstrMemory.td [WebAssembly] Fix names of WebAssemblyWrapper SDNodes. NFC 2021-09-02 13:54:44 -04:00
WebAssemblyInstrRef.td [WebAssembly] Implementation of intrinsic for ref.null and HeapType removal 2021-12-06 09:46:15 +01:00
WebAssemblyInstrSIMD.td [WebAssembly] Custom optimization for truncate 2021-12-14 08:42:39 -08:00
WebAssemblyInstrTable.td [WebAssembly] Implement table instruction intrinsics 2021-12-07 13:25:59 +01:00
WebAssemblyLateEHPrepare.cpp
WebAssemblyLowerBrUnless.cpp [llvm] Use make_early_inc_range (NFC) 2021-09-20 19:30:02 -07:00
WebAssemblyLowerEmscriptenEHSjLj.cpp [WebAssembly] Use cast<> instead of dyn_cast<> to avoid dereference of nullptr 2022-01-29 16:08:06 +00:00
WebAssemblyLowerGlobalDtors.cpp [NFC] Add missing <map> includes 2022-01-19 12:29:03 +01:00
WebAssemblyLowerRefTypesIntPtrConv.cpp [WebAssembly][NFC] Refactor WasmSymbol type setting code 2022-01-29 09:00:51 +01:00
WebAssemblyMCInstLower.cpp [WebAssembly][NFC] Refactor WasmSymbol type setting code 2022-01-29 09:00:51 +01:00
WebAssemblyMCInstLower.h
WebAssemblyMCLowerPrePass.cpp [WebAssembly] Refactor and fix emission of external IR global decls 2022-02-04 22:01:46 +01:00
WebAssemblyMachineFunctionInfo.cpp [WebAssembly][NFC] Refactor WasmSymbol type setting code 2022-01-29 09:00:51 +01:00
WebAssemblyMachineFunctionInfo.h [WebAssembly][NFC] Refactor WasmSymbol type setting code 2022-01-29 09:00:51 +01:00
WebAssemblyMemIntrinsicResults.cpp [llvm] Use make_early_inc_range (NFC) 2021-09-20 19:30:02 -07:00
WebAssemblyNullifyDebugValueLists.cpp
WebAssemblyOptimizeLiveIntervals.cpp [NFC] Use Register instead of unsigned 2022-01-19 20:17:04 +08:00
WebAssemblyOptimizeReturned.cpp [Target] Migrate from getNumArgOperands to arg_size (NFC) 2021-10-02 12:06:29 -07:00
WebAssemblyPeephole.cpp
WebAssemblyPrepareForLiveIntervals.cpp [NFC] Use Register instead of unsigned 2022-01-19 20:17:04 +08:00
WebAssemblyRegColoring.cpp [NFC] Use Register instead of unsigned 2022-01-19 20:17:04 +08:00
WebAssemblyRegNumbering.cpp [NFC] Use Register instead of unsigned 2022-01-19 20:17:04 +08:00
WebAssemblyRegStackify.cpp [NFC] Use Register instead of unsigned 2022-01-19 20:17:04 +08:00
WebAssemblyRegisterInfo.cpp
WebAssemblyRegisterInfo.h
WebAssemblyRegisterInfo.td
WebAssemblyReplacePhysRegs.cpp [MachineInstr] Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand 2021-10-07 16:08:52 +01:00
WebAssemblyRuntimeLibcallSignatures.cpp
WebAssemblyRuntimeLibcallSignatures.h
WebAssemblySelectionDAGInfo.cpp
WebAssemblySelectionDAGInfo.h
WebAssemblySetP2AlignOperands.cpp
WebAssemblySortRegion.cpp
WebAssemblySortRegion.h
WebAssemblySubtarget.cpp [Target] Remove redundant member initialization (NFC) 2022-01-06 22:01:44 -08:00
WebAssemblySubtarget.h [WebAssembly] Add relaxed-simd feature 2021-09-22 14:52:50 -07:00
WebAssemblyTargetMachine.cpp [WebAssembly] Support clang -fwasm-exceptions for bitcode 2021-12-16 16:49:24 -08:00
WebAssemblyTargetMachine.h
WebAssemblyTargetObjectFile.cpp
WebAssemblyTargetObjectFile.h
WebAssemblyTargetTransformInfo.cpp [BasicTTIImpl][LoopUnroll] getUnrollingPreferences(): emit ORE remark when advising against unrolling due to a call in a loop 2021-08-03 00:57:26 +03:00
WebAssemblyTargetTransformInfo.h [Target][CodeGen] Remove default CostKind arguments on inner/impl TTI overrides 2021-09-22 15:28:08 +01:00

README.txt

//===-- README.txt - Notes for WebAssembly code gen -----------------------===//

The object format emitted by the WebAssembly backed is documented in:

  * https://github.com/WebAssembly/tool-conventions/blob/main/Linking.md

The C ABI is described in:

  * https://github.com/WebAssembly/tool-conventions/blob/main/BasicCABI.md

For more information on WebAssembly itself, see the home page:

  * https://webassembly.github.io/

Emscripten provides a C/C++ compilation environment based on clang which
includes standard libraries, tools, and packaging for producing WebAssembly
applications that can run in browsers and other environments.

wasi-sdk provides a more minimal C/C++ SDK based on clang, llvm and a libc based
on musl, for producing WebAssemmbly applictions that use the WASI ABI.

Rust provides WebAssembly support integrated into Cargo. There are two
main options:
 - wasm32-unknown-unknown, which provides a relatively minimal environment
   that has an emphasis on being "native"
 - wasm32-unknown-emscripten, which uses Emscripten internally and
   provides standard C/C++ libraries, filesystem emulation, GL and SDL
   bindings
For more information, see:
  * https://www.hellorust.com/

The following documents contain some information on the semantics and binary
encoding of WebAssembly itself:
  * https://github.com/WebAssembly/design/blob/main/Semantics.md
  * https://github.com/WebAssembly/design/blob/main/BinaryEncoding.md

Some notes on ways that the generated code could be improved follow:

//===---------------------------------------------------------------------===//

Br, br_if, and br_table instructions can support having a value on the value
stack across the jump (sometimes). We should (a) model this, and (b) extend
the stackifier to utilize it.

//===---------------------------------------------------------------------===//

The min/max instructions aren't exactly a<b?a:b because of NaN and negative zero
behavior. The ARM target has the same kind of min/max instructions and has
implemented optimizations for them; we should do similar optimizations for
WebAssembly.

//===---------------------------------------------------------------------===//

AArch64 runs SeparateConstOffsetFromGEPPass, followed by EarlyCSE and LICM.
Would these be useful to run for WebAssembly too? Also, it has an option to
run SimplifyCFG after running the AtomicExpand pass. Would this be useful for
us too?

//===---------------------------------------------------------------------===//

Register stackification uses the VALUE_STACK physical register to impose
ordering dependencies on instructions with stack operands. This is pessimistic;
we should consider alternate ways to model stack dependencies.

//===---------------------------------------------------------------------===//

Lots of things could be done in WebAssemblyTargetTransformInfo.cpp. Similarly,
there are numerous optimization-related hooks that can be overridden in
WebAssemblyTargetLowering.

//===---------------------------------------------------------------------===//

Instead of the OptimizeReturned pass, which should consider preserving the
"returned" attribute through to MachineInstrs and extending the
MemIntrinsicResults pass to do this optimization on calls too. That would also
let the WebAssemblyPeephole pass clean up dead defs for such calls, as it does
for stores.

//===---------------------------------------------------------------------===//

Consider implementing optimizeSelect, optimizeCompareInstr, optimizeCondBranch,
optimizeLoadInstr, and/or getMachineCombinerPatterns.

//===---------------------------------------------------------------------===//

Find a clean way to fix the problem which leads to the Shrink Wrapping pass
being run after the WebAssembly PEI pass.

//===---------------------------------------------------------------------===//

When setting multiple local variables to the same constant, we currently get
code like this:

    i32.const   $4=, 0
    i32.const   $3=, 0

It could be done with a smaller encoding like this:

    i32.const   $push5=, 0
    local.tee   $push6=, $4=, $pop5
    local.copy  $3=, $pop6

//===---------------------------------------------------------------------===//

WebAssembly registers are implicitly initialized to zero. Explicit zeroing is
therefore often redundant and could be optimized away.

//===---------------------------------------------------------------------===//

Small indices may use smaller encodings than large indices.
WebAssemblyRegColoring and/or WebAssemblyRegRenumbering should sort registers
according to their usage frequency to maximize the usage of smaller encodings.

//===---------------------------------------------------------------------===//

Many cases of irreducible control flow could be transformed more optimally
than via the transform in WebAssemblyFixIrreducibleControlFlow.cpp.

It may also be worthwhile to do transforms before register coloring,
particularly when duplicating code, to allow register coloring to be aware of
the duplication.

//===---------------------------------------------------------------------===//

WebAssemblyRegStackify could use AliasAnalysis to reorder loads and stores more
aggressively.

//===---------------------------------------------------------------------===//

WebAssemblyRegStackify is currently a greedy algorithm. This means that, for
example, a binary operator will stackify with its user before its operands.
However, if moving the binary operator to its user moves it to a place where
its operands can't be moved to, it would be better to leave it in place, or
perhaps move it up, so that it can stackify its operands. A binary operator
has two operands and one result, so in such cases there could be a net win by
preferring the operands.

//===---------------------------------------------------------------------===//

Instruction ordering has a significant influence on register stackification and
coloring. Consider experimenting with the MachineScheduler (enable via
enableMachineScheduler) and determine if it can be configured to schedule
instructions advantageously for this purpose.

//===---------------------------------------------------------------------===//

WebAssemblyRegStackify currently assumes that the stack must be empty after
an instruction with no return values, however wasm doesn't actually require
this. WebAssemblyRegStackify could be extended, or possibly rewritten, to take
full advantage of what WebAssembly permits.

//===---------------------------------------------------------------------===//

Add support for mergeable sections in the Wasm writer, such as for strings and
floating-point constants.

//===---------------------------------------------------------------------===//

The function @dynamic_alloca_redzone in test/CodeGen/WebAssembly/userstack.ll
ends up with a local.tee in its prolog which has an unused result, requiring
an extra drop:

    global.get  $push8=, 0
    local.tee   $push9=, 1, $pop8
    drop        $pop9
    [...]

The prologue code initially thinks it needs an FP register, but later it
turns out to be unneeded, so one could either approach this by being more
clever about not inserting code for an FP in the first place, or optimizing
away the copy later.

//===---------------------------------------------------------------------===//