forked from OSchip/llvm-project
5aa8014ca8
An instruction like this will need to allocate some stack space for the
last parameter:
%x = call addrspace(1) i16 @bar(i64 undef, i64 undef, i16 undef, i16 0)
This worked fine when passing an actual value (in this case 0). However,
when passing undef, no value was pushed to the stack and therefore no
push instructions were created. This caused an unbalanced stack leading
to interesting results.
This commit fixes that by replacing the push logic with a regular stack
adjustment and stack-relative load/stores. This is less efficient but at
least it correctly compiles the code.
I can think of a few improvements in the future:
* The stack should have been adjusted in the function prologue when
there are no allocas in the function.
* Many (if not most) stack adjustments can be replaced by
pushing/popping the values directly. Exactly like the previous code
attempted but didn't do correctly.
* Small stack adjustments can be done more efficiently with a few
push/pop instructions (pushing/popping bogus values), both for code
size and for speed.
All in all, as long as there are no allocas in the function I think that
it is almost always more efficient to emit regular push/pop
instructions. This is however left for future optimizations.
Differential Revision: https://reviews.llvm.org/D78581
|
||
|---|---|---|
| .. | ||
| atomics | ||
| calling-conv/c | ||
| features | ||
| inline-asm | ||
| integration | ||
| intrinsics | ||
| pseudo | ||
| relax-mem | ||
| PR31344.ll | ||
| PR31345.ll | ||
| PR37143.ll | ||
| add.ll | ||
| alloca.ll | ||
| and.ll | ||
| avr-rust-issue-123.ll | ||
| branch-relaxation-long.ll | ||
| branch-relaxation.ll | ||
| brind.ll | ||
| call.ll | ||
| clear-bss.ll | ||
| cmp.ll | ||
| com.ll | ||
| copy-data-to-ram.ll | ||
| ctlz.ll | ||
| ctpop.ll | ||
| cttz.ll | ||
| directmem.ll | ||
| div.ll | ||
| dynalloca.ll | ||
| eor.ll | ||
| expand-integer-failure.ll | ||
| frame.ll | ||
| frmidx-iterator-bug.ll | ||
| hardware-mul.ll | ||
| high-pressure-on-ptrregs.ll | ||
| icall-func-pointer-correct-addr-space.ll | ||
| impossible-reg-to-reg-copy.ll | ||
| interrupts.ll | ||
| io.ll | ||
| issue-cannot-select-bswap.ll | ||
| issue-regalloc-stackframe-folding-earlyclobber.ll | ||
| large-return-size.ll | ||
| lit.local.cfg | ||
| load.ll | ||
| lower-formal-args-struct-return.ll | ||
| lower-formal-arguments-assertion.ll | ||
| neg.ll | ||
| no-print-operand-twice.ll | ||
| or.ll | ||
| pre-schedule.ll | ||
| progmem-extended.ll | ||
| progmem.ll | ||
| rem.ll | ||
| return.ll | ||
| rot.ll | ||
| runtime-trig.ll | ||
| rust-avr-bug-37.ll | ||
| rust-avr-bug-95.ll | ||
| rust-avr-bug-99.ll | ||
| rust-avr-bug-112.ll | ||
| sections.ll | ||
| select-must-add-unconditional-jump.ll | ||
| sext.ll | ||
| shift.ll | ||
| sign-extension.ll | ||
| smul-with-overflow.ll | ||
| software-mul.ll | ||
| std-ldd-immediate-overflow.ll | ||
| store-undef.ll | ||
| store.ll | ||
| sub.ll | ||
| trunc.ll | ||
| umul-with-overflow.ll | ||
| umul.with.overflow.i16-bug.ll | ||
| unaligned-atomic-loads.ll | ||
| varargs.ll | ||
| xor.ll | ||
| zext.ll | ||