forked from OSchip/llvm-project
819ff6b945
Currently, when marshaling a dynamic AST matchers, we check for the type and value validity of matcher arguments at the same time for some matchers. For instance, when marshaling hasAttr("foo"), the argument is first type checked to ensure it's a string and then checked to see if that string can locate an attribute with that name. Similar happens for other enumeration conversions like cast kinds or unary operator kinds. If the type is correct but the value cannot be looked up, we make a best-effort attempt to find a nearby name that the user might have meant, but if one cannot be found, we throw our hands up and claim the types don't match. This has an unfortunate behavior that when the user enters something of the correct type but a best guess cannot be located, you get confusing error messages like: Incorrect type for arg 1. (Expected = string) != (Actual = String). This patch splits the argument check into two parts: if the types don't match, give a type diagnostic. If the type matches but the value cannot be converted, give a best guess diagnostic or a value could not be located diagnostic. This addresses PR47057. |
||
---|---|---|
.. | ||
Dynamic | ||
ASTMatchersInternalTest.cpp | ||
ASTMatchersNarrowingTest.cpp | ||
ASTMatchersNodeTest.cpp | ||
ASTMatchersTest.h | ||
ASTMatchersTraversalTest.cpp | ||
CMakeLists.txt | ||
GtestMatchersTest.cpp |