forked from OSchip/llvm-project
6f1da6e345
The standard library functions ::isprint/std::isprint have platform-
and locale-dependent behavior which makes LLVM's output less
predictable. In particular, regression tests my fail depending on the
implementation of these functions.
Implement llvm::isPrint in StringExtras.h with a standard behavior and
replace all uses of ::isprint/std::isprint by a call it llvm::isPrint.
The function is inlined and does not look up language settings so it
should perform better than the standard library's version.
Such a replacement has already been done for isdigit, isalpha, isxdigit
in r314883. gtest does the same in gtest-printers.cc using the following
justification:
// Returns true if c is a printable ASCII character. We test the
// value of c directly instead of calling isprint(), which is buggy on
// Windows Mobile.
inline bool IsPrintableAscii(wchar_t c) {
return 0x20 <= c && c <= 0x7E;
}
Similar issues have also been encountered by Julia:
https://github.com/JuliaLang/julia/issues/7416
I noticed the problem myself when on Windows isprint('\t') started to
evaluate to true (see https://stackoverflow.com/questions/51435249) and
thus caused several unit tests to fail. The result of isprint doesn't
seem to be well-defined even for ASCII characters. Therefore I suggest
to replace isprint by a platform-independent version.
Differential Revision: https://reviews.llvm.org/D49680
llvm-svn: 338034
|
||
|---|---|---|
| .. | ||
| APFloatTest.cpp | ||
| APIntTest.cpp | ||
| APSIntTest.cpp | ||
| AnyTest.cpp | ||
| ArrayRefTest.cpp | ||
| BitVectorTest.cpp | ||
| BitmaskEnumTest.cpp | ||
| BreadthFirstIteratorTest.cpp | ||
| BumpPtrListTest.cpp | ||
| CMakeLists.txt | ||
| DAGDeltaAlgorithmTest.cpp | ||
| DeltaAlgorithmTest.cpp | ||
| DenseMapTest.cpp | ||
| DenseSetTest.cpp | ||
| DepthFirstIteratorTest.cpp | ||
| EquivalenceClassesTest.cpp | ||
| FoldingSet.cpp | ||
| FunctionExtrasTest.cpp | ||
| FunctionRefTest.cpp | ||
| HashingTest.cpp | ||
| IListBaseTest.cpp | ||
| IListIteratorTest.cpp | ||
| IListNodeBaseTest.cpp | ||
| IListNodeTest.cpp | ||
| IListSentinelTest.cpp | ||
| IListTest.cpp | ||
| ImmutableMapTest.cpp | ||
| ImmutableSetTest.cpp | ||
| IntEqClassesTest.cpp | ||
| IntervalMapTest.cpp | ||
| IntrusiveRefCntPtrTest.cpp | ||
| IteratorTest.cpp | ||
| MakeUniqueTest.cpp | ||
| MapVectorTest.cpp | ||
| MappedIteratorTest.cpp | ||
| OptionalTest.cpp | ||
| PackedVectorTest.cpp | ||
| PointerEmbeddedIntTest.cpp | ||
| PointerIntPairTest.cpp | ||
| PointerSumTypeTest.cpp | ||
| PointerUnionTest.cpp | ||
| PostOrderIteratorTest.cpp | ||
| PriorityWorklistTest.cpp | ||
| RangeAdapterTest.cpp | ||
| SCCIteratorTest.cpp | ||
| STLExtrasTest.cpp | ||
| ScopeExitTest.cpp | ||
| SequenceTest.cpp | ||
| SetVectorTest.cpp | ||
| SimpleIListTest.cpp | ||
| SmallPtrSetTest.cpp | ||
| SmallSetTest.cpp | ||
| SmallStringTest.cpp | ||
| SmallVectorTest.cpp | ||
| SparseBitVectorTest.cpp | ||
| SparseMultiSetTest.cpp | ||
| SparseSetTest.cpp | ||
| StatisticTest.cpp | ||
| StringExtrasTest.cpp | ||
| StringMapTest.cpp | ||
| StringRefTest.cpp | ||
| StringSwitchTest.cpp | ||
| TestGraph.h | ||
| TinyPtrVectorTest.cpp | ||
| TripleTest.cpp | ||
| TwineTest.cpp | ||
| VariadicFunctionTest.cpp | ||