llvm-project/lldb/source/Breakpoint
Jim Ingham 658f6ed152 Make ignore counts work as "after stop" modifiers so they play nicely with conditions
Previously ignore counts were checked when we stopped to do the sync callback in Breakpoint::ShouldStop. That meant we would do all the ignore count work even when
there is also a condition says the breakpoint should not stop.

That's wrong, lldb treats breakpoint hits that fail the thread or condition checks as "not having hit the breakpoint". So the ignore count check should happen after
the condition and thread checks in StopInfoBreakpoint::PerformAction.

The one side-effect of doing this is that if you have a breakpoint with a synchronous callback, it will run the synchronous callback before checking the ignore count.
That is probably a good thing, since this was already true of the condition and thread checks, so this removes an odd asymmetry. And breakpoints with sync callbacks
are all internal lldb breakpoints and there's not a really good reason why you would want one of these to use an ignore count (but not a condition or thread check...)

Differential Revision https://reviews.llvm.org/D103217
2021-06-01 18:22:27 -07:00
..
Breakpoint.cpp Make ignore counts work as "after stop" modifiers so they play nicely with conditions 2021-06-01 18:22:27 -07:00
BreakpointID.cpp [lldb][NFC] Use C++ versions of the deprecated C standard library headers 2021-05-26 12:46:12 +02:00
BreakpointIDList.cpp [lldb] Fix redundant newline in AppendError calls. 2020-07-20 23:11:56 -07:00
BreakpointList.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
BreakpointLocation.cpp Make ignore counts work as "after stop" modifiers so they play nicely with conditions 2021-06-01 18:22:27 -07:00
BreakpointLocationCollection.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
BreakpointLocationList.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
BreakpointName.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
BreakpointOptions.cpp Make the stop-on-sharedlibrary-events setting work. 2021-03-24 11:15:11 -07:00
BreakpointPrecondition.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
BreakpointResolver.cpp [lldb/Symbol] Fix column breakpoint `move_to_nearest_code` match 2021-05-05 05:07:50 +00:00
BreakpointResolverAddress.cpp [lldb][NFC] Remove dead code in BreakpointResolverAddress 2020-08-10 11:29:40 +02:00
BreakpointResolverFileLine.cpp [lldb] Refactor argument group by SourceLocationSpec (NFCI) 2021-05-04 23:04:31 +00:00
BreakpointResolverFileRegex.cpp [lldb] Refactor argument group by SourceLocationSpec (NFCI) 2021-05-04 23:04:31 +00:00
BreakpointResolverName.cpp [lldb][NFC] Remove all uses of StringRef::withNullAsEmpty in LLDB 2021-05-18 09:41:20 +02:00
BreakpointResolverScripted.cpp [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint 2020-03-04 16:56:50 +03:00
BreakpointSite.cpp [lldb][NFC] Use C++ versions of the deprecated C standard library headers 2021-05-26 12:46:12 +02:00
BreakpointSiteList.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
CMakeLists.txt [lldb/Breakpoint] Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation 2020-07-29 22:07:46 +03:00
Stoppoint.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
StoppointCallbackContext.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
StoppointSite.cpp [lldb/Breakpoint] Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation 2020-07-29 22:07:46 +03:00
Watchpoint.cpp [lldb/Breakpoint] Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation 2020-07-29 22:07:46 +03:00
WatchpointList.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
WatchpointOptions.cpp [lldb] Use std::make_unique<> (NFC) 2020-06-24 17:48:40 -07:00