forked from OSchip/llvm-project
99217fa8a0
Inside a switch the caseStmt() and defaultStmt() have a nested statement associated with them. Similarly, labelStmt() has a nested statement. These statements were being missed when looking for a compound-if of the form "if (x) return true; return false;" when the if is nested under one of these labelling constructs. Enhance the matchers to look for these nested statements using some private matcher hasSubstatement() traversal matcher on case, default and label statements. Add the private matcher hasSubstatementSequence() to match the compound "if (x) return true; return false;" pattern. - Add unit tests for private matchers and corresponding test infrastructure - Add corresponding test file readability-simplify-bool-expr-case.cpp. - Fix variable name copy/paste error in readability-simplify-bool-expr.cpp. - Drop the asserts, which were used only for debugging matchers. - Run clang-format on the whole check. - Move local functions out of anonymous namespace and declare state, per LLVM style guide - Declare labels constexpr - Declare visitor arguments as pointer to const - Drop braces around simple control statements per LLVM style guide - Prefer explicit arguments over default arguments to methods Differential Revision: https://reviews.llvm.org/D56303 Fixes #27078 |
||
|---|---|---|
| .. | ||
| AddConstTest.cpp | ||
| CMakeLists.txt | ||
| ClangTidyDiagnosticConsumerTest.cpp | ||
| ClangTidyOptionsTest.cpp | ||
| ClangTidyTest.h | ||
| DeclRefExprUtilsTest.cpp | ||
| GlobListTest.cpp | ||
| GoogleModuleTest.cpp | ||
| IncludeInserterTest.cpp | ||
| LLVMModuleTest.cpp | ||
| NamespaceAliaserTest.cpp | ||
| ObjCModuleTest.cpp | ||
| OptionsProviderTest.cpp | ||
| OverlappingReplacementsTest.cpp | ||
| ReadabilityModuleTest.cpp | ||
| TransformerClangTidyCheckTest.cpp | ||
| UsingInserterTest.cpp | ||