llvm-project/polly/lib/Analysis
Tobias Grosser 349d1c3368 [ScopDetection] Remove redundant checks for endless loops
Summary:
Both `canUseISLTripCount()` and `addOverApproximatedRegion()` contained checks
to reject endless loops which are now removed and replaced by a single check
in `isValidLoop()`.

For reporting such loops the `ReportLoopOverlapWithNonAffineSubRegion` is
renamed to `ReportLoopHasNoExit`. The test case
`ReportLoopOverlapWithNonAffineSubRegion.ll` is adapted and renamed as well.

The schedule generation in `buildSchedule()` is based on the following
assumption:

Given some block B that is contained in a loop L and a SESE region R,
we assume that L is contained in R or the other way around.

However, this assumption is broken in the presence of endless loops that are
nested inside other loops. Therefore, in order to prevent erroneous behavior
in `buildSchedule()`, r265280 introduced a corresponding check in
`canUseISLTripCount()` to reject endless loops. Unfortunately, it was possible
to bypass this check with -polly-allow-nonaffine-loops which was fixed by adding
another check to reject endless loops in `allowOverApproximatedRegion()` in
r273905. Hence there existed two separate locations that handled this case.

Thank you Johannes Doerfert for helping to provide the above background
information.

Reviewers: Meinersbur, grosser

Subscribers: _jdoerfert, pollydev

Differential Revision: https://reviews.llvm.org/D24560

Contributed-by: Matthias Reisinger <d412vv1n@gmail.com>
llvm-svn: 281987
2016-09-20 17:05:22 +00:00
..
DependenceInfo.cpp Perform copying to created arrays according to the packing transformation 2016-09-14 06:26:09 +00:00
PolyhedralInfo.cpp Perform copying to created arrays according to the packing transformation 2016-09-14 06:26:09 +00:00
ScopBuilder.cpp Store the size of the outermost dimension in case of newly created arrays that require memory allocation. 2016-09-12 17:08:31 +00:00
ScopDetection.cpp [ScopDetection] Remove redundant checks for endless loops 2016-09-20 17:05:22 +00:00
ScopDetectionDiagnostic.cpp [ScopDetection] Remove redundant checks for endless loops 2016-09-20 17:05:22 +00:00
ScopGraphPrinter.cpp Migrate from NodeType * to NodeRef. 2016-08-22 22:30:27 +00:00
ScopInfo.cpp GPGPU: Detect read-only scalar arrays ... 2016-09-17 19:22:18 +00:00
ScopPass.cpp Decouple SCoP building logic from pass 2016-05-31 09:41:04 +00:00