forked from OSchip/llvm-project
4d79ec7fe8
This differs from the previous version by being more careful about template instantiation/specialization in order to prevent errors when building with clang -Werror. Specifically: * begin is not defined in the template and is instead instantiated when Head is. I think the warning when we don't do that is wrong (PR28815) but for now at least do it this way to avoid the warning. * Instead of performing template specializations in LLVM_INSTANTIATE_REGISTRY instead provide a template definition then do explicit instantiation. No compiler I've tried has problems with doing it the other way, but strictly speaking it's not permitted by the C++ standard so better safe than sorry. Original commit message: Currently the Registry class contains the vestiges of a previous attempt to allow plugins to be used on Windows without using BUILD_SHARED_LIBS, where a plugin would have its own copy of a registry and export it to be imported by the tool that's loading the plugin. This only works if the plugin is entirely self-contained with the only interface between the plugin and tool being the registry, and in particular this conflicts with how IR pass plugins work. This patch changes things so that instead the add_node function of the registry is exported by the tool and then imported by the plugin, which solves this problem and also means that instead of every plugin having to export every registry they use instead LLVM only has to export the add_node functions. This allows plugins that use a registry to work on Windows if LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is used. llvm-svn: 277806 |
||
|---|---|---|
| .. | ||
| boost | ||
| cert | ||
| cppcoreguidelines | ||
| llvm | ||
| misc | ||
| modernize | ||
| mpi | ||
| performance | ||
| plugin | ||
| readability | ||
| tool | ||
| utils | ||
| CMakeLists.txt | ||
| ClangTidy.cpp | ||
| ClangTidy.h | ||
| ClangTidyDiagnosticConsumer.cpp | ||
| ClangTidyDiagnosticConsumer.h | ||
| ClangTidyModule.cpp | ||
| ClangTidyModule.h | ||
| ClangTidyModuleRegistry.h | ||
| ClangTidyOptions.cpp | ||
| ClangTidyOptions.h | ||
| add_new_check.py | ||
| rename_check.py | ||