forked from OSchip/llvm-project
e8f7241e0b
The Scudo C unit tests are currently non-hermetic. In particular, adding or removing a transfer batch is a global state of the allocator that persists between tests. This can cause flakiness in ScudoWrappersCTest.MallInfo, because the creation or teardown of a batch causes mallinfo's uordblks or fordblks to move up or down by the size of a transfer batch on malloc/free. It's my opinion that uordblks and fordblks should track the statistics related to the user's malloc() and free() usage, and not the state of the internal allocator structures. Thus, excluding the transfer batches from stat collection does the trick and makes these tests pass. Repro instructions of the bug: 1. ninja ./projects/compiler-rt/lib/scudo/standalone/tests/ScudoCUnitTest-x86_64-Test 2. ./projects/compiler-rt/lib/scudo/standalone/tests/ScudoCUnitTest-x86_64-Test --gtest_filter=ScudoWrappersCTest.MallInfo Reviewed By: cryptoad Differential Revision: https://reviews.llvm.org/D101653 |
||
|---|---|---|
| .. | ||
| cmake | ||
| docs | ||
| include | ||
| lib | ||
| test | ||
| tools | ||
| unittests | ||
| utils | ||
| www | ||
| .clang-tidy | ||
| .gitignore | ||
| CMakeLists.txt | ||
| CODE_OWNERS.TXT | ||
| CREDITS.TXT | ||
| LICENSE.TXT | ||
| README.txt | ||
README.txt
Compiler-RT ================================ This directory and its subdirectories contain source code for the compiler support routines. Compiler-RT is open source software. You may freely distribute it under the terms of the license agreement found in LICENSE.txt. ================================