llvm-project/clang
Volodymyr Sapsai 9d540f1539 [Lex] Fix crash on code completion in comment in included file.
This fixes PR32732 by updating CurLexerKind to reflect available lexers.
We were hitting null pointer in Preprocessor::Lex because CurLexerKind
was CLK_Lexer but CurLexer was null. And we set it to null in
Preprocessor::HandleEndOfFile when exiting a file with code completion
point.

To reproduce the crash it is important for a comment to be inside a
class specifier. In this case in Parser::ParseClassSpecifier we improve
error recovery by pushing a semicolon token back into the preprocessor
and later on try to lex a token because we haven't reached the end of
file.

Also clang crashes only on code completion in included file, i.e. when
IncludeMacroStack is not empty. Though we reset CurLexer even if include
stack is empty. The difference is that during pushing back a semicolon
token, preprocessor calls EnterCachingLexMode which decides it is
already in caching mode because various lexers are null and
IncludeMacroStack is not empty. As the result, CurLexerKind remains
CLK_Lexer instead of updating to CLK_CachingLexer.

rdar://problem/34787685

Reviewers: akyrtzi, doug.gregor, arphaman

Reviewed By: arphaman

Subscribers: cfe-commits, kfunk, arphaman, nemanjai, kbarton

Differential Revision: https://reviews.llvm.org/D41688

llvm-svn: 323008
2018-01-19 23:41:47 +00:00
..
INPUTS
bindings Remove duplicate python libclang changes from r320748 2017-12-14 23:40:42 +00:00
cmake [Fuchsia] Remove LLDB from the toolchain distribution 2018-01-11 04:25:30 +00:00
docs [WebAssembly] Add target flags for sign-ext opcodes. 2018-01-19 17:16:32 +00:00
examples [analyzer] introduce getSVal(Stmt *) helper on ExplodedNode, make sure the helper is used consistently 2018-01-17 20:27:29 +00:00
include [AArch64] Add ARMv8.2-A FP16 scalar intrinsics 2018-01-19 23:11:18 +00:00
lib [Lex] Fix crash on code completion in comment in included file. 2018-01-19 23:41:47 +00:00
runtime [clang] Use add_llvm_install_targets 2017-11-30 22:35:02 +00:00
test [Lex] Fix crash on code completion in comment in included file. 2018-01-19 23:41:47 +00:00
tools c-index-test: small fix to CXString handling and disposal 2018-01-18 20:21:07 +00:00
unittests [clang-format] Adds a canonical delimiter to raw string formatting 2018-01-19 16:18:47 +00:00
utils [AArch64] Add ARMv8.2-A FP16 scalar intrinsics 2018-01-19 23:11:18 +00:00
www DR126: partially implement the const-correct rules for exception handler matching. 2018-01-13 05:05:45 +00:00
.arcconfig [clang] Set up .arcconfig to point to new Diffusion C repository 2017-11-27 17:21:24 +00:00
.clang-format
.clang-tidy
.gitignore
CMakeLists.txt [cmake] Also pass CMAKE_ASM_COMPILER_ID to next stage when bootstrapping 2018-01-19 18:31:12 +00:00
CODE_OWNERS.TXT Change code owner for Clang Static Analyzer to Devin Coughlin. 2017-11-17 23:19:04 +00:00
INSTALL.txt
LICENSE.TXT
ModuleInfo.txt
NOTES.txt
README.txt Test commit 2017-10-21 16:03:17 +00:00

README.txt

//===----------------------------------------------------------------------===//
// C Language Family Front-end
//===----------------------------------------------------------------------===//

Welcome to Clang.  This is a compiler front-end for the C family of languages
(C, C++, Objective-C, and Objective-C++) which is built as part of the LLVM
compiler infrastructure project.

Unlike many other compiler frontends, Clang is useful for a number of things
beyond just compiling code: we intend for Clang to be host to a number of
different source-level tools.  One example of this is the Clang Static Analyzer.

If you're interested in more (including how to build Clang) it is best to read
the relevant web sites.  Here are some pointers:

Information on Clang:             http://clang.llvm.org/
Building and using Clang:         http://clang.llvm.org/get_started.html
Clang Static Analyzer:            http://clang-analyzer.llvm.org/
Information on the LLVM project:  http://llvm.org/

If you have questions or comments about Clang, a great place to discuss them is
on the Clang development mailing list:
  http://lists.llvm.org/mailman/listinfo/cfe-dev

If you find a bug in Clang, please file it in the LLVM bug tracker:
  http://llvm.org/bugs/