forked from OSchip/llvm-project
208e3f5d9b
LLDB is supposed to ask the Clang Driver what the default module cache path is and then use that value as the default for the `symbols.clang-modules-cache-path` setting. However, we use the property type `String` to change `symbols.clang-modules-cache-path` even though the type of that setting is `FileSpec`, so the setter will simply do nothing and return `false`. We also don't check the return value of the setter, so this whole code ends up not doing anything at all. This changes the setter to use the correct property type and adds an assert that we actually successfully set the default path. Also adds a test that checks that the default value for this setting is never unset/empty path as this would effectively disable the import-std-module feature from working by default. Reviewed By: JDevlieghere, shafik Differential Revision: https://reviews.llvm.org/D92772 |
||
|---|---|---|
| .. | ||
| Inputs | ||
| TestDefaultModuleCachePath.test | ||
| TestDisableColor.test | ||
| TestDisassemblyFormat.test | ||
| TestEchoCommands.test | ||
| TestFrameFormatColor.test | ||
| TestFrameFormatMangling.test | ||
| TestFrameFormatNoColor.test | ||
| TestLineMarkerColor.test | ||
| TestModuleCacheSanity.test | ||
| TestSettingsSet.test | ||
| TestSettingsWrite.test | ||
| TestStopCommandSourceOnError.test | ||