llvm-project/lldb/source
Michael Buch 09f608fda5 [lldb][ClangExpression] Remove storage-class check when creating AsmLabel
This check was put in place to prevent static functions
from translation units outside the one that the current
expression is evaluated from taking precedence over functions
in the global namespace. However, this is really a different
bug. LLDB lumps functions from all CUs into a single AST and
ends up picking the file-static even when C++ context rules
wouldn't allow that to happen.

This patch removes the check so we apply the AsmLabel to all
FunctionDecls we create from DWARF if we have a linkage name
available. This makes the code-path easier to reason about and
allows calling static functions in contexts where we previously
would've chosen the wrong function.

We also flip the XFAILs in the API test to reflect what effect
this change has.

**Testing**

* Fixed API tests and added XFAIL

Differential Revision: https://reviews.llvm.org/D132231
2022-08-22 13:22:20 +01:00
..
API Revert "[cmake] Use `CMAKE_INSTALL_LIBDIR` too" 2022-08-18 22:46:32 -04:00
Breakpoint Implement better path matching in FileSpecList::FindCompatibleIndex(...). 2022-08-08 15:20:38 -07:00
Commands [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread 2022-08-17 12:20:10 -07:00
Core Remove redundant initialization of Optional (NFC) 2022-08-20 21:18:28 -07:00
DataFormatters Move FormattersMatchCandidate flags to a struct. 2022-08-09 10:48:49 -07:00
Expression [LLDB] Add basic floating point ops to IR interpreter 2022-08-10 16:34:52 +03:00
Host [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro 2022-08-20 12:52:21 -04:00
Initialization [lldb] Remove FileSystem::Initialize from FileCollector 2022-03-03 13:22:38 -08:00
Interpreter [lldb] LLVM_FALLTHROUGH => [[fallthrough]]. NFC 2022-08-08 11:31:49 -07:00
Plugins [lldb][ClangExpression] Remove storage-class check when creating AsmLabel 2022-08-22 13:22:20 +01:00
Symbol [lldb] Automatically unwrap parameter packs in template argument accessors 2022-08-16 18:10:14 -07:00
Target Remove redundant initialization of Optional (NFC) 2022-08-20 21:18:28 -07:00
Utility Use range-based for loops (NFC) 2022-08-20 21:18:32 -07:00
Version [lldb] Fix LLDB_FULL_VERSION_STRING 2022-01-19 14:20:22 -08:00
CMakeLists.txt [lldb] Make lldbVersion a full fledged library 2021-12-08 15:14:34 -08:00