forked from OSchip/llvm-project
693eedb138
making it no longer even remotely simple. The pass will now be more of a "full loop unswitching" pass rather than anything substantively simpler than any other approach. I plan to rename it accordingly once the dust settles. The key ideas of the new loop unswitcher are carried over for non-trivial unswitching: 1) Fully unswitch a branch or switch instruction from inside of a loop to outside of it. 2) Update the CFG and IR. This avoids needing to "remember" the unswitched branches as well as avoiding excessively cloning and reliance on complex parts of simplify-cfg to cleanup the cfg. 3) Update the analyses (where we can) rather than just blowing them away or relying on something else updating them. Sadly, #3 is somewhat compromised here as the dominator tree updates were too complex for me to want to reason about. I will need to make another attempt to do this now that we have a nice dynamic update API for dominators. However, we do adhere to #3 w.r.t. LoopInfo. This approach also adds an important principls specific to non-trivial unswitching: not *all* of the loop will be duplicated when unswitching. This fact allows us to compute the cost in terms of how much *duplicate* code is inserted rather than just on raw size. Unswitching conditions which essentialy partition loops will work regardless of the total loop size. Some remaining issues that I will be addressing in subsequent commits: - Handling unstructured control flow. - Unswitching 'switch' cases instead of just branches. - Moving to the dynamic update API for dominators. Some high-level, interesting limitationsV that folks might want to push on as follow-ups but that I don't have any immediate plans around: - We could be much more clever about not cloning things that will be deleted. In fact, we should be able to delete *nothing* and do a minimal number of clones. - There are many more interesting selection criteria for which branch to unswitch that we might want to look at. One that I'm interested in particularly are a set of conditions which all exit the loop and which can be merged into a single unswitched test of them. Differential revision: https://reviews.llvm.org/D34200 llvm-svn: 318549 |
||
|---|---|---|
| .. | ||
| 2006-06-13-SingleEntryPHI.ll | ||
| 2006-06-27-DeadSwitchCase.ll | ||
| 2007-05-09-Unreachable.ll | ||
| 2007-05-09-tl.ll | ||
| 2007-07-12-ExitDomInfo.ll | ||
| 2007-07-13-DomInfo.ll | ||
| 2007-07-18-DomInfo.ll | ||
| 2007-08-01-Dom.ll | ||
| 2007-08-01-LCSSA.ll | ||
| 2007-10-04-DomFrontier.ll | ||
| 2008-06-02-DomInfo.ll | ||
| 2008-06-17-DomFrontier.ll | ||
| 2010-11-18-LCSSA.ll | ||
| 2011-06-02-CritSwitch.ll | ||
| 2011-09-26-EHCrash.ll | ||
| 2012-04-02-IndirectBr.ll | ||
| 2012-04-30-LoopUnswitch-LPad-Crash.ll | ||
| 2012-05-20-Phi.ll | ||
| 2015-09-18-Addrspace.ll | ||
| LIV-loop-condtion.ll | ||
| basictest.ll | ||
| cleanuppad.ll | ||
| copy-metadata.ll | ||
| crash.ll | ||
| exponential-behavior.ll | ||
| infinite-loop.ll | ||
| msan.ll | ||
| nontrivial-unswitch-cost.ll | ||
| nontrivial-unswitch.ll | ||
| preserve-analyses.ll | ||
| trivial-unswitch.ll | ||