forked from OSchip/llvm-project
17a6ad05c1
all RTTI types, and since we don't use RTTI anymore since clang and llvm don't
we don't really need this header file. All shared pointer definitions have
been moved into "lldb-forward.h".
Defined std::tr1::weak_ptr definitions for all of the types that inherit from
enable_shared_from_this() in "lldb-forward.h" in preparation for thread
hardening our public API.
The first in the thread hardening check-ins. First we start with SBThread.
We have issues in our lldb::SB API right now where if you have one object
that is being used by two threads we have a race condition. Consider the
following code:
1 int
2 SBThread::SomeFunction()
3 {
4 int result = -1;
5 if (m_opaque_sp)
6 {
7 result = m_opaque_sp->DoSomething();
8 }
9 return result;
10 }
And now this happens:
Thread 1 enters any SBThread function and checks its m_opaque_sp and is about
to execute the code on line 7 but hasn't yet
Thread 2 gets to run and class sb_thread.Clear() which calls m_opaque_sp.clear()
and clears the contents of the shared pointer member
Thread 1 now crashes when it resumes.
The solution is to use std::tr1::weak_ptr. Now the SBThread class contains a
lldb::ThreadWP (weak pointer to our lldb_private::Thread class) and this
function would look like:
1 int
2 SBThread::SomeFunction()
3 {
4 int result = -1;
5 ThreadSP thread_sp(m_opaque_wp.lock());
6 if (thread_sp)
7 {
8 result = m_opaque_sp->DoSomething();
9 }
10 return result;
11 }
Now we have a solid thread safe API where we get a local copy of our thread
shared pointer from our weak_ptr and then we are guaranteed it can't go away
during our function.
So lldb::SBThread has been thread hardened, more checkins to follow shortly.
llvm-svn: 149218
|
||
|---|---|---|
| .. | ||
| Python | ||
| build-lldb-llvm-clang | ||
| build-llvm.pl | ||
| build-swig-wrapper-classes.sh | ||
| buildbot.py | ||
| checkpoint-llvm.pl | ||
| clang.DebuggerCastResultToId.diff | ||
| clang.complete-type-being-converted.diff | ||
| clang.complete-type-being-laid-out.diff | ||
| clang.complete-type-ivar-lookup.diff | ||
| clang.instantiate-complete-type.diff | ||
| clang.is-being-completed-from-lexical-storage.diff | ||
| clang.require-complete-type.diff | ||
| disasm-gdb-remote.pl | ||
| finish-swig-wrapper-classes.sh | ||
| generate-vers.pl | ||
| install-lldb.sh | ||
| lldb.swig | ||
| llvm.communicate-triple.diff | ||
| llvm.delete-target-machine.diff | ||
| sed-sources | ||