llvm-project/lldb/cmake/modules
Alex Langford 7e7f79ccb1 [CMake] Don't explicitly use LLVM_LIBRARY_DIR in standalone builds
Summary:
This line is unnecessary because add_llvm_executable will handle
linking the correct LLVM libraries for you. LLDB standalone builds are totally
fine without this.

In the best case, having this line here is harmless. In the worst case it can
cause link issues.

If you build lldb-server for android using the standalone build, this line
will cause LLVM_LIBRARY_DIR to be the first place you look for libraries.
This is an issue because if you built libc++, it will try to link against
that one instead of the one from the android NDK.  Meanwhile, the LLVM libraries
you're linking against were linked against the libc++ from the NDK.

Ideally, we would take advantage of the AFTER option for link_directories(), but
that was not available in LLDB's minimum supported version of CMake (CMake 3.4.3).

Differential Revision: https://reviews.llvm.org/D60180

llvm-svn: 357817
2019-04-05 21:01:50 +00:00
..
AddLLDB.cmake Revert "[CMake] Avoid clang-tablegen-targets dependency when building sphinx docs (experimental)" 2019-03-12 15:54:35 +00:00
EmbedAppleVersion.cmake Fixing the Xcode build that I broke in r286479 2016-11-10 21:30:16 +00:00
FindLibEdit.cmake Fix a typo in FindLibEdit.cmake 2019-03-15 14:03:52 +00:00
LLDBConfig.cmake [Cmake] Unify python variables 2019-03-29 17:35:42 +00:00
LLDBFramework.cmake [build] Rename clang-headers to clang-resource-headers 2019-03-04 21:19:53 +00:00
LLDBGenerateConfig.cmake [cmake] Move LLDB_DISABLE_LIBEDIT handling code into a central place 2019-02-28 16:04:54 +00:00
LLDBStandalone.cmake [CMake] Don't explicitly use LLVM_LIBRARY_DIR in standalone builds 2019-04-05 21:01:50 +00:00
debugserverConfig.cmake [CMake] Move debugserver options to separate debugserverConfig.cmake 2019-01-04 12:46:38 +00:00