forked from OSchip/llvm-project
43917720a7
Summary: This patch changes a few (small) things around for compatibility purposes for the current Android & Fuchsia work: - `realloc`'ing some memory that was not allocated with `malloc`, `calloc` or `realloc`, while UB according to http://pubs.opengroup.org/onlinepubs/009695399/functions/realloc.html is more common that one would think. We now only check this if `DeallocationTypeMismatch` is set; change the "mismatch" error messages to be more homogeneous; - some sketchily written but widely used libraries expect a call to `realloc` to copy the usable size of the old chunk to the new one instead of the requested size. We have to begrundingly abide by this de-facto standard. This doesn't seem to impact security either way, unless someone comes up with something we didn't think about; - the CRC32 intrinsics for 64-bit take a 64-bit first argument. This is misleading as the upper 32 bits end up being ignored. This was also raising `-Wconversion` errors. Change things to take a `u32` as first argument. This also means we were (and are) only using 32 bits of the Cookie - not a big thing, but worth mentioning. - Includes-wise: prefer `stddef.h` to `cstddef`, move `scudo_flags.h` where it is actually needed. - Add tests for the memalign-realloc case, and the realloc-usable-size one. (Edited typos) Reviewers: alekseyshl Reviewed By: alekseyshl Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D36754 llvm-svn: 311018 |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| scudo_allocator.cpp | ||
| scudo_allocator.h | ||
| scudo_allocator_combined.h | ||
| scudo_allocator_secondary.h | ||
| scudo_crc32.cpp | ||
| scudo_crc32.h | ||
| scudo_flags.cpp | ||
| scudo_flags.h | ||
| scudo_flags.inc | ||
| scudo_interceptors.cpp | ||
| scudo_new_delete.cpp | ||
| scudo_termination.cpp | ||
| scudo_tls.h | ||
| scudo_tls_android.cpp | ||
| scudo_tls_android.inc | ||
| scudo_tls_context_android.inc | ||
| scudo_tls_context_linux.inc | ||
| scudo_tls_linux.cpp | ||
| scudo_tls_linux.inc | ||
| scudo_utils.cpp | ||
| scudo_utils.h | ||