llvm-project/mlir/tools/mlir-tblgen
Markus Böck 52b8fe9b6e [mlir] Fix attaching side effects on `FlatSymbolRefAttr`
The names of the generated attribute getters for ops changed some time ago. The method created from the attribute name returns the return type and an additional method of the same name with Attr as suffix is generated which returns the actual attribute as its storage type.

The code generating effects however was using the methods without the Attr suffix, which is a problem in the case of FlatSymbolRefAttr as it has a return type of llvm::StringRef. This would lead to compilation errors as the constructor of SideEffects::EffectInstance expects a SymbolRefAttr in this case.

This patch simply fixes the generated effects code to use the Attr suffixed getter to get the actual storage type of the attribute.

Differential Revision: https://reviews.llvm.org/D117194
2022-01-13 19:57:01 +01:00
..
AttrOrTypeDefGen.cpp Revert "Define a `cppAccessorType` to const-ref in APFloatParameter and update ODS emitter to use it for verifier signatures" 2022-01-03 06:32:50 +00:00
AttrOrTypeFormatGen.cpp Add a `qualified` directive to the Op, Attribute, and Type declarative assembly format 2022-01-11 01:30:19 +00:00
AttrOrTypeFormatGen.h Adjust "end namespace" comment in MLIR to match new agree'd coding style 2021-12-08 06:05:26 +00:00
CMakeLists.txt [mlir][ods] AttrOrTypeGen uses Class 2021-12-01 16:53:23 +00:00
CodeGenHelpers.cpp [mlir][ods] Fix unused uniqued attr constraint 2021-11-14 23:23:14 +00:00
DialectGen.cpp Apply clang-tidy fixes for performance-unnecessary-value-param to MLIR (NFC) 2022-01-02 01:45:18 +00:00
DirectiveCommonGen.cpp Apply clang-tidy fixes for readability-container-size-empty for MLIR (NFC) 2022-01-02 01:56:38 +00:00
DocGenUtilities.h Mass update the MLIR license header to mention "Part of the LLVM project" 2020-01-26 03:58:30 +00:00
EnumsGen.cpp [mlir][ODS] Support specialized Attribute class for Enums 2021-03-17 16:44:24 +03:00
FormatGen.cpp Add a `qualified` directive to the Op, Attribute, and Type declarative assembly format 2022-01-11 01:30:19 +00:00
FormatGen.h Add a `qualified` directive to the Op, Attribute, and Type declarative assembly format 2022-01-11 01:30:19 +00:00
LLVMIRConversionGen.cpp Fix more clang-tidy cleanups in mlir/ (NFC) 2021-12-22 20:53:11 +00:00
LLVMIRIntrinsicGen.cpp Apply clang-tidy fixes for performance-for-range-copy to MLIR (NFC) 2022-01-02 01:13:42 +00:00
OpClass.cpp [mlir][ods] ODS ops get an `extraClassDefinition` 2022-01-06 01:43:26 +00:00
OpClass.h [mlir][ods] ODS ops get an `extraClassDefinition` 2022-01-06 01:43:26 +00:00
OpDefinitionsGen.cpp [mlir] Fix attaching side effects on `FlatSymbolRefAttr` 2022-01-13 19:57:01 +01:00
OpDocGen.cpp Apply clang-tidy fixes for performance-unnecessary-value-param to MLIR (NFC) 2022-01-02 01:45:18 +00:00
OpFormatGen.cpp Add a `qualified` directive to the Op, Attribute, and Type declarative assembly format 2022-01-11 01:30:19 +00:00
OpFormatGen.h Adjust "end namespace" comment in MLIR to match new agree'd coding style 2021-12-08 06:05:26 +00:00
OpGenHelpers.cpp [mlir] Hoist out getRequestedOpDefinitions helper 2021-04-06 12:53:28 -07:00
OpGenHelpers.h Adjust "end namespace" comment in MLIR to match new agree'd coding style 2021-12-08 06:05:26 +00:00
OpInterfacesGen.cpp [mlir][Interfaces] Add a extraSharedClassDeclaration field 2022-01-12 14:12:08 -08:00
OpPythonBindingGen.cpp Apply clang-tidy fixes for performance-for-range-copy to MLIR (NFC) 2022-01-02 01:13:42 +00:00
PassCAPIGen.cpp Add basic Python bindings for the PassManager and bind libTransforms 2020-11-10 19:55:21 +00:00
PassDocGen.cpp [mlir][Pass] Update the PassGen to generate base classes instead of utilities 2020-04-07 14:08:52 -07:00
PassGen.cpp Fix more clang-tidy cleanups in mlir/ (NFC) 2021-12-22 20:53:11 +00:00
RewriterGen.cpp Adjust "end namespace" comment in MLIR to match new agree'd coding style 2021-12-08 06:05:26 +00:00
SPIRVUtilsGen.cpp [mlir] Remove unused "using" (NFC) 2022-01-01 09:14:19 -08:00
StructsGen.cpp [mlir][NFC] Replace references to Identifier with StringAttr 2021-11-16 17:36:26 +00:00
mlir-tblgen.cpp Apply clang-tidy fixes for performance-unnecessary-value-param to MLIR (NFC) 2022-01-02 01:45:18 +00:00