forked from OSchip/llvm-project
6d354ed72e
Before this patch, debugify would insert debug value intrinsics before the terminating instruction in a block. This had the advantage of being simple, but was a bit too simple/unrealistic. This patch teaches debugify to insert debug values immediately after their operand defs. This enables better testing of the compiler. For example, with this patch, `opt -debugify-each` is able to identify a vectorizer DI-invariance bug fixed in llvm.org/PR32761. In this bug, the vectorizer produced different output with/without debug info present. Reverting Davide's bugfix locally, I see: $ ~/scripts/opt-check-dbg-invar.sh ./bin/opt \ .../SLPVectorizer/AArch64/spillcost-di.ll -slp-vectorizer Comparing: -slp-vectorizer .../SLPVectorizer/AArch64/spillcost-di.ll Baseline: /var/folders/j8/t4w0bp8j6x1g6fpghkcb4sjm0000gp/T/tmp.iYYeL1kf With DI : /var/folders/j8/t4w0bp8j6x1g6fpghkcb4sjm0000gp/T/tmp.sQtQSeet 9,11c9,11 < %5 = getelementptr inbounds %0, %0* %2, i64 %0, i32 1 < %6 = bitcast i64* %4 to <2 x i64>* < %7 = load <2 x i64>, <2 x i64>* %6, align 8, !tbaa !0 --- > %5 = load i64, i64* %4, align 8, !tbaa !0 > %6 = getelementptr inbounds %0, %0* %2, i64 %0, i32 1 > %7 = load i64, i64* %6, align 8, !tbaa !5 12a13 > store i64 %5, i64* %8, align 8, !tbaa !0 14,15c15 < %10 = bitcast i64* %8 to <2 x i64>* < store <2 x i64> %7, <2 x i64>* %10, align 8, !tbaa !0 --- > store i64 %7, i64* %9, align 8, !tbaa !5 :: Found a test case ^ Running this over the *.ll files in tree, I found four additional examples which compile differently with/without DI present. I plan on filing bugs for these. llvm-svn: 334118 |
||
|---|---|---|
| .. | ||
| 2011-03-25-DSEMiscompile.ll | ||
| 2011-09-06-EndOfFunction.ll | ||
| 2011-09-06-MemCpy.ll | ||
| 2016-07-17-UseAfterFree.ll | ||
| OverwriteStoreBegin.ll | ||
| OverwriteStoreEnd.ll | ||
| PartialStore.ll | ||
| atomic.ll | ||
| calloc-store.ll | ||
| combined-partial-overwrites.ll | ||
| const-pointers.ll | ||
| crash.ll | ||
| cs-cs-aliasing.ll | ||
| debuginfo.ll | ||
| dominate.ll | ||
| fence.ll | ||
| free.ll | ||
| inst-limits.ll | ||
| int_sideeffect.ll | ||
| invariant.start.ll | ||
| launder.invariant.group.ll | ||
| libcalls.ll | ||
| lifetime.ll | ||
| mda-with-dbg-values.ll | ||
| memintrinsics.ll | ||
| merge-stores-big-endian.ll | ||
| merge-stores.ll | ||
| no-targetdata.ll | ||
| operand-bundles.ll | ||
| pr11390.ll | ||
| simple.ll | ||