llvm-project/llvm/lib/Target/WebAssembly
Wouter van Oortmerssen a7a3751775 [WebAssembly] Fixed FrameBaseLocal not being set.
Summary:
Fixes: https://bugs.llvm.org/show_bug.cgi?id=44920

WebAssemblyRegColoring may merge the vreg that currently represents
the FrameBase with one representing an argument.
WebAssemblyExplicitLocals picks up the corresponding local when
a vreg is first added to the Reg2Local mapping, except when it is
an argument instruction which are handled separately.

Note that this does not change that vregs representing the FrameBase
may get merged, it is not clear to me that this may have other
effects we may want to avoid?

Reviewers: dschuff

Reviewed By: dschuff

Subscribers: azakai, sbc100, hiraditya, aheejin, sunfish, llvm-commits, jgravelle-google

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D75718
2020-03-09 17:29:36 -07:00
..
AsmParser [MCStreamer] De-capitalize EmitValue EmitIntValue{,InHex} 2020-02-14 23:08:40 -08:00
Disassembler CMake: Make most target symbols hidden by default 2020-01-14 19:46:52 -08:00
MCTargetDesc [WebAssembly] Replace all calls with generalized multivalue calls 2020-02-18 15:55:20 -08:00
TargetInfo CMake: Make most target symbols hidden by default 2020-01-14 19:46:52 -08:00
CMakeLists.txt [WebAssembly] Replace all calls with generalized multivalue calls 2020-02-18 15:55:20 -08:00
LLVMBuild.txt
README.txt
WebAssembly.h [WebAssembly] Replace all calls with generalized multivalue calls 2020-02-18 15:55:20 -08:00
WebAssembly.td [WebAssembly] Update bleeding-edge CPU features 2020-01-24 14:27:35 -08:00
WebAssemblyAddMissingPrototypes.cpp Make llvm::StringRef to std::string conversions explicit. 2020-01-28 23:25:25 +01:00
WebAssemblyArgumentMove.cpp
WebAssemblyAsmPrinter.cpp [MCStreamer] De-capitalize EmitValue EmitIntValue{,InHex} 2020-02-14 23:08:40 -08:00
WebAssemblyAsmPrinter.h [AsmPrinter][MCStreamer] De-capitalize EmitInstruction and EmitCFI* 2020-02-13 22:08:55 -08:00
WebAssemblyCFGSort.cpp Update spelling of {analyze,insert,remove}Branch in strings and comments 2020-01-21 10:15:38 -06:00
WebAssemblyCFGStackify.cpp Prune a LegacyDivergenceAnalysis and MachineLoopInfo include each 2019-10-19 01:31:09 +00:00
WebAssemblyDebugValueManager.cpp [WebAssembly] Use TargetIndex operands in DbgValue to track WebAssembly operands locations 2019-12-20 14:39:05 -08:00
WebAssemblyDebugValueManager.h [WebAssembly] Use TargetIndex operands in DbgValue to track WebAssembly operands locations 2019-12-20 14:39:05 -08:00
WebAssemblyExceptionInfo.cpp Sink all InitializePasses.h includes 2019-11-13 16:34:37 -08:00
WebAssemblyExceptionInfo.h
WebAssemblyExplicitLocals.cpp [WebAssembly] Fixed FrameBaseLocal not being set. 2020-03-09 17:29:36 -07:00
WebAssemblyFastISel.cpp [WebAssembly] Replace all calls with generalized multivalue calls 2020-02-18 15:55:20 -08:00
WebAssemblyFixFunctionBitcasts.cpp
WebAssemblyFixIrreducibleControlFlow.cpp [WebAssembly] Fix a non-determinism problem in FixIrreducibleControlFlow 2020-02-21 17:05:46 -08:00
WebAssemblyFrameLowering.cpp [WebAssembly] Preserve debug frame base information through register coloring 2020-01-28 16:58:15 -08:00
WebAssemblyFrameLowering.h [WebAssembly] Track frame registers through VReg and local allocation 2020-01-17 17:23:56 -08:00
WebAssemblyISD.def [WebAssembly] Replace all calls with generalized multivalue calls 2020-02-18 15:55:20 -08:00
WebAssemblyISelDAGToDAG.cpp [WebAssembly] Replace all calls with generalized multivalue calls 2020-02-18 15:55:20 -08:00
WebAssemblyISelLowering.cpp [WebAssembly] Simplify extract_vector lowering 2020-02-25 13:54:48 -08:00
WebAssemblyISelLowering.h Reland "[WebAssembly] Expand setcc of v2i64" 2019-11-01 10:34:01 -07:00
WebAssemblyInstrAtomics.td [WebAssembly] Remove unused memory instructions and patterns 2019-09-23 20:04:59 +00:00
WebAssemblyInstrBulkMemory.td Reapply r372285 "GlobalISel: Don't materialize immarg arguments to intrinsics" 2019-09-19 16:26:14 +00:00
WebAssemblyInstrCall.td [WebAssembly] Replace all calls with generalized multivalue calls 2020-02-18 15:55:20 -08:00
WebAssemblyInstrControl.td [WebAssembly] Make returns variadic 2019-10-09 21:42:08 +00:00
WebAssemblyInstrConv.td [WebAssembly] Trapping fptoint builtins and intrinsics 2019-10-15 01:11:51 +00:00
WebAssemblyInstrFloat.td [WebAssembly] Fix miscompile of select with and 2019-11-15 16:22:01 -08:00
WebAssemblyInstrFormats.td
WebAssemblyInstrInfo.cpp [WebAssembly] Use TargetIndex operands in DbgValue to track WebAssembly operands locations 2019-12-20 14:39:05 -08:00
WebAssemblyInstrInfo.h [WebAssembly] Use TargetIndex operands in DbgValue to track WebAssembly operands locations 2019-12-20 14:39:05 -08:00
WebAssemblyInstrInfo.td [WebAssembly] Replace all calls with generalized multivalue calls 2020-02-18 15:55:20 -08:00
WebAssemblyInstrInteger.td
WebAssemblyInstrMemory.td [WebAssembly] Remove unused memory instructions and patterns 2019-09-23 20:04:59 +00:00
WebAssemblyInstrRef.td
WebAssemblyInstrSIMD.td [WebAssembly] Simplify extract_vector lowering 2020-02-25 13:54:48 -08:00
WebAssemblyLateEHPrepare.cpp [WebAssembly] Replace all calls with generalized multivalue calls 2020-02-18 15:55:20 -08:00
WebAssemblyLowerBrUnless.cpp
WebAssemblyLowerEmscriptenEHSjLj.cpp [wasm] Unbreak after 5fc5c7db38. NFCI. 2020-02-17 15:49:49 +01:00
WebAssemblyLowerGlobalDtors.cpp
WebAssemblyMCInstLower.cpp [WebAssembly] Replace all calls with generalized multivalue calls 2020-02-18 15:55:20 -08:00
WebAssemblyMCInstLower.h [WebAssembly] Allow multivalue types in block signature operands 2019-10-15 18:28:22 +00:00
WebAssemblyMachineFunctionInfo.cpp [WebAssembly] Make returns variadic 2019-10-09 21:42:08 +00:00
WebAssemblyMachineFunctionInfo.h [WebAssembly] Preserve debug frame base information through register coloring 2020-01-28 16:58:15 -08:00
WebAssemblyMemIntrinsicResults.cpp [WebAssembly] Replace all calls with generalized multivalue calls 2020-02-18 15:55:20 -08:00
WebAssemblyOptimizeLiveIntervals.cpp [WebAssembly] Track frame registers through VReg and local allocation 2020-01-17 17:23:56 -08:00
WebAssemblyOptimizeReturned.cpp
WebAssemblyPeephole.cpp [WebAssembly] Replace all calls with generalized multivalue calls 2020-02-18 15:55:20 -08:00
WebAssemblyPrepareForLiveIntervals.cpp
WebAssemblyRegColoring.cpp [WebAssembly] Preserve debug frame base information through register coloring 2020-01-28 16:58:15 -08:00
WebAssemblyRegNumbering.cpp
WebAssemblyRegStackify.cpp [WebAssembly] Fix memory bug introduced in 5286180999 2020-02-19 15:07:45 -08:00
WebAssemblyRegisterInfo.cpp [WebAssembly] Track frame registers through VReg and local allocation 2020-01-17 17:23:56 -08:00
WebAssemblyRegisterInfo.h
WebAssemblyRegisterInfo.td
WebAssemblyReplacePhysRegs.cpp [WebAssembly] Track frame registers through VReg and local allocation 2020-01-17 17:23:56 -08:00
WebAssemblyRuntimeLibcallSignatures.cpp [WebAssembly] Add cbrt function signatures 2020-02-13 13:18:42 -08:00
WebAssemblyRuntimeLibcallSignatures.h
WebAssemblySelectionDAGInfo.cpp
WebAssemblySelectionDAGInfo.h
WebAssemblySetP2AlignOperands.cpp
WebAssemblySubtarget.cpp
WebAssemblySubtarget.h [WebAssembly] Add reference types target feature 2020-01-24 14:26:27 -08:00
WebAssemblyTargetMachine.cpp [WebAssembly] Replace all calls with generalized multivalue calls 2020-02-18 15:55:20 -08:00
WebAssemblyTargetMachine.h Reland "[WebAssembly][InstrEmitter] Foundation for multivalue call lowering" 2020-02-18 13:49:46 -08:00
WebAssemblyTargetObjectFile.cpp
WebAssemblyTargetObjectFile.h
WebAssemblyTargetTransformInfo.cpp [ARM] Teach the Arm cost model that a Shift can be folded into other instructions 2019-12-09 10:24:33 +00:00
WebAssemblyTargetTransformInfo.h [ARM] Teach the Arm cost model that a Shift can be folded into other instructions 2019-12-09 10:24:33 +00:00
WebAssemblyUtilities.cpp [WebAssembly] Replace all calls with generalized multivalue calls 2020-02-18 15:55:20 -08:00
WebAssemblyUtilities.h Reland "[WebAssembly][InstrEmitter] Foundation for multivalue call lowering" 2020-02-18 13:49:46 -08:00
known_gcc_test_failures.txt

README.txt

//===-- README.txt - Notes for WebAssembly code gen -----------------------===//

This WebAssembly backend is presently under development.

The most notable feature which is not yet stable is the ".o" file format.
".o" file support is needed for many common ways of using LLVM, such as
using it through "clang -c", so this backend is not yet considered widely
usable. However, this backend is usable within some language toolchain
packages:

Emscripten provides a C/C++ compilation environment that includes standard
libraries, tools, and packaging for producing WebAssembly applications that
can run in browsers and other environments. For more information, see the
Emscripten documentation in general, and this page in particular:

  * https://github.com/kripken/emscripten/wiki/New-WebAssembly-Backend

Rust provides WebAssembly support integrated into Cargo. There are two
main options:
 - wasm32-unknown-unknown, which provides a relatively minimal environment
   that has an emphasis on being "native"
 - wasm32-unknown-emscripten, which uses Emscripten internally and
   provides standard C/C++ libraries, filesystem emulation, GL and SDL
   bindings
For more information, see:
  * https://www.hellorust.com/


This backend does not yet support debug info. Full DWARF support needs a
design for how DWARF should be represented in WebAssembly. Sourcemap support
has an existing design and some corresponding browser implementations, so it
just needs implementing in LLVM.

Work-in-progress documentation for the ".o" file format is here:

  * https://github.com/WebAssembly/tool-conventions/blob/master/Linking.md

A corresponding linker implementation is also under development:

  * https://lld.llvm.org/WebAssembly.html

For more information on WebAssembly itself, see the home page:
  * https://webassembly.github.io/

The following documents contain some information on the semantics and binary
encoding of WebAssembly itself:
  * https://github.com/WebAssembly/design/blob/master/Semantics.md
  * https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md

The backend is built, tested and archived on the following waterfall:
  https://wasm-stat.us

The backend's bringup is done in part by using the GCC torture test suite, since
it doesn't require C library support. Current known failures are in
known_gcc_test_failures.txt, all other tests should pass. The waterfall will
turn red if not. Once most of these pass, further testing will use LLVM's own
test suite. The tests can be run locally using:
  https://github.com/WebAssembly/waterfall/blob/master/src/compile_torture_tests.py

Some notes on ways that the generated code could be improved follow:

//===---------------------------------------------------------------------===//

Br, br_if, and br_table instructions can support having a value on the value
stack across the jump (sometimes). We should (a) model this, and (b) extend
the stackifier to utilize it.

//===---------------------------------------------------------------------===//

The min/max instructions aren't exactly a<b?a:b because of NaN and negative zero
behavior. The ARM target has the same kind of min/max instructions and has
implemented optimizations for them; we should do similar optimizations for
WebAssembly.

//===---------------------------------------------------------------------===//

AArch64 runs SeparateConstOffsetFromGEPPass, followed by EarlyCSE and LICM.
Would these be useful to run for WebAssembly too? Also, it has an option to
run SimplifyCFG after running the AtomicExpand pass. Would this be useful for
us too?

//===---------------------------------------------------------------------===//

Register stackification uses the VALUE_STACK physical register to impose
ordering dependencies on instructions with stack operands. This is pessimistic;
we should consider alternate ways to model stack dependencies.

//===---------------------------------------------------------------------===//

Lots of things could be done in WebAssemblyTargetTransformInfo.cpp. Similarly,
there are numerous optimization-related hooks that can be overridden in
WebAssemblyTargetLowering.

//===---------------------------------------------------------------------===//

Instead of the OptimizeReturned pass, which should consider preserving the
"returned" attribute through to MachineInstrs and extending the
MemIntrinsicResults pass to do this optimization on calls too. That would also
let the WebAssemblyPeephole pass clean up dead defs for such calls, as it does
for stores.

//===---------------------------------------------------------------------===//

Consider implementing optimizeSelect, optimizeCompareInstr, optimizeCondBranch,
optimizeLoadInstr, and/or getMachineCombinerPatterns.

//===---------------------------------------------------------------------===//

Find a clean way to fix the problem which leads to the Shrink Wrapping pass
being run after the WebAssembly PEI pass.

//===---------------------------------------------------------------------===//

When setting multiple local variables to the same constant, we currently get
code like this:

    i32.const   $4=, 0
    i32.const   $3=, 0

It could be done with a smaller encoding like this:

    i32.const   $push5=, 0
    local.tee   $push6=, $4=, $pop5
    local.copy  $3=, $pop6

//===---------------------------------------------------------------------===//

WebAssembly registers are implicitly initialized to zero. Explicit zeroing is
therefore often redundant and could be optimized away.

//===---------------------------------------------------------------------===//

Small indices may use smaller encodings than large indices.
WebAssemblyRegColoring and/or WebAssemblyRegRenumbering should sort registers
according to their usage frequency to maximize the usage of smaller encodings.

//===---------------------------------------------------------------------===//

Many cases of irreducible control flow could be transformed more optimally
than via the transform in WebAssemblyFixIrreducibleControlFlow.cpp.

It may also be worthwhile to do transforms before register coloring,
particularly when duplicating code, to allow register coloring to be aware of
the duplication.

//===---------------------------------------------------------------------===//

WebAssemblyRegStackify could use AliasAnalysis to reorder loads and stores more
aggressively.

//===---------------------------------------------------------------------===//

WebAssemblyRegStackify is currently a greedy algorithm. This means that, for
example, a binary operator will stackify with its user before its operands.
However, if moving the binary operator to its user moves it to a place where
its operands can't be moved to, it would be better to leave it in place, or
perhaps move it up, so that it can stackify its operands. A binary operator
has two operands and one result, so in such cases there could be a net win by
preferring the operands.

//===---------------------------------------------------------------------===//

Instruction ordering has a significant influence on register stackification and
coloring. Consider experimenting with the MachineScheduler (enable via
enableMachineScheduler) and determine if it can be configured to schedule
instructions advantageously for this purpose.

//===---------------------------------------------------------------------===//

WebAssemblyRegStackify currently assumes that the stack must be empty after
an instruction with no return values, however wasm doesn't actually require
this. WebAssemblyRegStackify could be extended, or possibly rewritten, to take
full advantage of what WebAssembly permits.

//===---------------------------------------------------------------------===//

Add support for mergeable sections in the Wasm writer, such as for strings and
floating-point constants.

//===---------------------------------------------------------------------===//

The function @dynamic_alloca_redzone in test/CodeGen/WebAssembly/userstack.ll
ends up with a local.tee in its prolog which has an unused result, requiring
an extra drop:

    global.get  $push8=, 0
    local.tee   $push9=, 1, $pop8
    drop        $pop9
    [...]

The prologue code initially thinks it needs an FP register, but later it
turns out to be unneeded, so one could either approach this by being more
clever about not inserting code for an FP in the first place, or optimizing
away the copy later.

//===---------------------------------------------------------------------===//