forked from OSchip/llvm-project
81f522a62e
Check that the `MDLocalVariable::getInlinedAt()` in a debug info
intrinsic's variable always matches the `MDLocation::getInlinedAt()` of
its `!dbg` attachment.
The goal here is to get rid of `MDLocalVariable::getInlinedAt()`
entirely (PR22778), since it's expensive and unnecessary, but I'll let
this verifier check bake for a while (a week maybe?) first. I've
updated the testcases that had the wrong value for `inlinedAt:`.
This checks that things are sane in the IR, but currently things go out
of whack in a few places in the backend. I'll follow shortly with
assertions in the backend (with code fixes).
If you have out-of-tree testcases that just started failing, here's how
I updated these ones:
1. The verifier check gives you the basic block, function, instruction,
and relevant metadata arguments (metadata numbering doesn't
necessarily match the source file, unfortunately).
2. Look at the `@llvm.dbg.*()` instruction, and compare the
`inlinedAt:` fields of the variable argument (second `metadata`
argument) and the `!dbg` attachment.
3. Figure out based on the variable `scope:` chain and the functions in
the file whether the variable has been inlined (and into what), so
you can determine which `inlinedAt:` is actually correct. In all of
the in-tree testcases, the `!MDLocation()` was correct and the
`!MDLocalVariable()` was wrong, but YMMV.
4. Duplicate the metadata that you're going to change, and add/drop the
`inlinedAt:` field from one of them. Be careful that the other
references to the same metadata node point at the correct one.
llvm-svn: 234021
|
||
|---|---|---|
| .. | ||
| 2002-03-28-UninitializedVal.ll | ||
| 2002-05-01-ShouldNotPromoteThisAlloca.ll | ||
| 2003-04-10-DFNotFound.ll | ||
| 2003-04-18-DeadBlockProblem.ll | ||
| 2003-04-24-MultipleIdenticalSuccessors.ll | ||
| 2003-06-26-IterativePromote.ll | ||
| 2003-10-05-DeadPHIInsertion.ll | ||
| 2005-06-30-ReadBeforeWrite.ll | ||
| 2005-11-28-Crash.ll | ||
| 2007-08-27-VolatileLoadsStores.ll | ||
| ConvertDebugInfo.ll | ||
| ConvertDebugInfo2.ll | ||
| PromoteMemToRegister.ll | ||
| UndefValuesMerge.ll | ||
| atomic.ll | ||
| crash.ll | ||
| ignore-lifetime.ll | ||