llvm-project/llvm/lib/Target/WebAssembly
Derek Schuff 6f69783f1f [WebAssembly] Fix for 0xc call_indirect changes
Summary:
Need to reorder the operands to have the callee as the last argument.
Adds a pseudo-instruction, and a pass to lower it into a real
call_indirect.

This is the first of two options for how to fix the problem.

Reviewers: dschuff, sunfish

Subscribers: jfb, beanz, mgorny, llvm-commits

Differential Revision: https://reviews.llvm.org/D25708

llvm-svn: 284840
2016-10-21 16:38:07 +00:00
..
Disassembler Move the global variables representing each Target behind accessor function 2016-10-09 23:00:34 +00:00
InstPrinter [WebAssemby] Implement block signatures. 2016-10-06 22:29:32 +00:00
MCTargetDesc Move the global variables representing each Target behind accessor function 2016-10-09 23:00:34 +00:00
TargetInfo Fix WebAssembly build after r283702. 2016-10-10 06:49:55 +00:00
CMakeLists.txt [WebAssembly] Fix for 0xc call_indirect changes 2016-10-21 16:38:07 +00:00
LLVMBuild.txt Add asm.js-style setjmp/longjmp handling for wasm 2016-08-31 22:40:34 +00:00
README.txt [WebAssembly] Update to more stack-machine-oriented terminology. 2016-10-03 22:43:53 +00:00
WebAssembly.h [WebAssembly] Fix for 0xc call_indirect changes 2016-10-21 16:38:07 +00:00
WebAssembly.td [WebAssembly] Initial SIMD128 support. 2016-08-02 23:16:09 +00:00
WebAssemblyArgumentMove.cpp Use StringRef in Pass/PassManager APIs (NFC) 2016-10-01 02:56:57 +00:00
WebAssemblyAsmPrinter.cpp Move the global variables representing each Target behind accessor function 2016-10-09 23:00:34 +00:00
WebAssemblyCFGStackify.cpp [WebAssemby] Implement block signatures. 2016-10-06 22:29:32 +00:00
WebAssemblyCallIndirectFixup.cpp [WebAssembly] Fix for 0xc call_indirect changes 2016-10-21 16:38:07 +00:00
WebAssemblyFastISel.cpp [WebAssembly] Fix for 0xc call_indirect changes 2016-10-21 16:38:07 +00:00
WebAssemblyFixIrreducibleControlFlow.cpp Use StringRef in Pass/PassManager APIs (NFC) 2016-10-01 02:56:57 +00:00
WebAssemblyFrameLowering.cpp [WebAssembly] Remove the output operand from stores. 2016-10-06 22:08:28 +00:00
WebAssemblyFrameLowering.h Change eliminateCallFramePseudoInstr() to return an iterator 2016-03-31 18:33:38 +00:00
WebAssemblyISD.def [WebAssembly] Update for spec change from tableswitch to br_table. 2016-03-08 03:18:12 +00:00
WebAssemblyISelDAGToDAG.cpp Use StringRef in Pass/PassManager APIs (NFC) 2016-10-01 02:56:57 +00:00
WebAssemblyISelLowering.cpp [WebAssemby] Implement block signatures. 2016-10-06 22:29:32 +00:00
WebAssemblyISelLowering.h Pass DebugLoc and SDLoc by const ref. 2016-06-12 15:39:02 +00:00
WebAssemblyInstrAtomics.td
WebAssemblyInstrCall.td [WebAssembly] Fix for 0xc call_indirect changes 2016-10-21 16:38:07 +00:00
WebAssemblyInstrControl.td [WebAssemby] Implement block signatures. 2016-10-06 22:29:32 +00:00
WebAssemblyInstrConv.td [WebAssembly] Add binary-encoding opcode values to instruction descriptions. 2016-10-05 21:24:08 +00:00
WebAssemblyInstrFloat.td [WebAssembly] Add binary-encoding opcode values to instruction descriptions. 2016-10-05 21:24:08 +00:00
WebAssemblyInstrFormats.td [WebAssembly] Add binary-encoding opcode values to instruction descriptions. 2016-10-05 21:24:08 +00:00
WebAssemblyInstrInfo.cpp Finish renaming remaining analyzeBranch functions 2016-09-14 20:43:16 +00:00
WebAssemblyInstrInfo.h Finish renaming remaining analyzeBranch functions 2016-09-14 20:43:16 +00:00
WebAssemblyInstrInfo.td [WebAssemby] Implement block signatures. 2016-10-06 22:29:32 +00:00
WebAssemblyInstrInteger.td [WebAssembly] Add binary-encoding opcode values to instruction descriptions. 2016-10-05 21:24:08 +00:00
WebAssemblyInstrMemory.td [WebAssembly] Remove the output operand from stores. 2016-10-06 22:08:28 +00:00
WebAssemblyInstrSIMD.td [WebAssembly] Initial SIMD128 support. 2016-08-02 23:16:09 +00:00
WebAssemblyLowerBrUnless.cpp [WebAssembly] Update to more stack-machine-oriented terminology. 2016-10-03 22:43:53 +00:00
WebAssemblyLowerEmscriptenEHSjLj.cpp Use StringRef in Pass/PassManager APIs (NFC) 2016-10-01 02:56:57 +00:00
WebAssemblyMCInstLower.cpp [WebAssembly] Make CFG stackification independent of basic-block labels. 2016-01-12 19:14:46 +00:00
WebAssemblyMCInstLower.h [WebAssembly] Define WebAssembly-specific relocation codes. 2016-01-11 23:38:05 +00:00
WebAssemblyMachineFunctionInfo.cpp [WebAssemby] Implement block signatures. 2016-10-06 22:29:32 +00:00
WebAssemblyMachineFunctionInfo.h [WebAssemby] Implement block signatures. 2016-10-06 22:29:32 +00:00
WebAssemblyOptimizeLiveIntervals.cpp Use StringRef in Pass/PassManager APIs (NFC) 2016-10-01 02:56:57 +00:00
WebAssemblyOptimizeReturned.cpp Use StringRef in Pass/PassManager APIs (NFC) 2016-10-01 02:56:57 +00:00
WebAssemblyPeephole.cpp [WebAssembly] Remove the output operand from stores. 2016-10-06 22:08:28 +00:00
WebAssemblyPrepareForLiveIntervals.cpp Use StringRef in Pass/PassManager APIs (NFC) 2016-10-01 02:56:57 +00:00
WebAssemblyRegColoring.cpp Use StringRef in Pass/PassManager APIs (NFC) 2016-10-01 02:56:57 +00:00
WebAssemblyRegNumbering.cpp Use StringRef in Pass/PassManager APIs (NFC) 2016-10-01 02:56:57 +00:00
WebAssemblyRegStackify.cpp [WebAssembly] Update to more stack-machine-oriented terminology. 2016-10-03 22:43:53 +00:00
WebAssemblyRegisterInfo.cpp [WebAssembly] Remove the output operand from stores. 2016-10-06 22:08:28 +00:00
WebAssemblyRegisterInfo.h [WebAssembly] Initial varargs support. 2015-12-04 23:22:35 +00:00
WebAssemblyRegisterInfo.td [WebAssembly] Update to more stack-machine-oriented terminology. 2016-10-03 22:43:53 +00:00
WebAssemblyReplacePhysRegs.cpp [WebAssembly] Update to more stack-machine-oriented terminology. 2016-10-03 22:43:53 +00:00
WebAssemblySelectionDAGInfo.cpp
WebAssemblySelectionDAGInfo.h Rename TargetSelectionDAGInfo into SelectionDAGTargetInfo and move it to CodeGen/ 2016-01-27 16:32:26 +00:00
WebAssemblySetP2AlignOperands.cpp [WebAssembly] Remove the output operand from stores. 2016-10-06 22:08:28 +00:00
WebAssemblyStoreResults.cpp Use StringRef in Pass/PassManager APIs (NFC) 2016-10-01 02:56:57 +00:00
WebAssemblySubtarget.cpp [WebAssembly] Disable the MachineScheduler. 2016-05-18 20:19:02 +00:00
WebAssemblySubtarget.h [WebAssembly] Move useAA() out of line to make it more convenient to experiment with. 2015-12-05 19:27:18 +00:00
WebAssemblyTargetMachine.cpp [WebAssembly] Fix for 0xc call_indirect changes 2016-10-21 16:38:07 +00:00
WebAssemblyTargetMachine.h [WebAssembly] Update WebAssembly target for r269988. 2016-05-19 03:00:05 +00:00
WebAssemblyTargetObjectFile.cpp [WebAssembly] Convert WebAssemblyTargetObjectFile to TargetLoweringObjectFileELF 2015-12-17 04:55:44 +00:00
WebAssemblyTargetObjectFile.h [WebAssembly] Convert WebAssemblyTargetObjectFile to TargetLoweringObjectFileELF 2015-12-17 04:55:44 +00:00
WebAssemblyTargetTransformInfo.cpp [WebAssembly] Basic TargetTransformInfo support for SIMD128. 2016-05-23 22:47:07 +00:00
WebAssemblyTargetTransformInfo.h Do a sweep over move ctors and remove those that are identical to the default. 2016-10-20 12:20:28 +00:00
known_gcc_test_failures.txt [WebAssembly] Update known test failures 2016-09-02 16:26:24 +00:00

README.txt

//===-- README.txt - Notes for WebAssembly code gen -----------------------===//

This WebAssembly backend is presently in a very early stage of development.
The code should build and not break anything else, but don't expect a lot more
at this point.

For more information on WebAssembly itself, see the design documents:
  * https://github.com/WebAssembly/design/blob/master/README.md

The following documents contain some information on the planned semantics and
binary encoding of WebAssembly itself:
  * https://github.com/WebAssembly/design/blob/master/AstSemantics.md
  * https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md

The backend is built, tested and archived on the following waterfall:
  https://wasm-stat.us

The backend's bringup is done using the GCC torture test suite first since it
doesn't require C library support. Current known failures are in
known_gcc_test_failures.txt, all other tests should pass. The waterfall will
turn red if not. Once most of these pass, further testing will use LLVM's own
test suite. The tests can be run locally using:
  https://github.com/WebAssembly/waterfall/blob/master/src/compile_torture_tests.py

//===---------------------------------------------------------------------===//

Br, br_if, and br_table instructions can support having a value on the value
stack across the jump (sometimes). We should (a) model this, and (b) extend
the stackifier to utilize it.

//===---------------------------------------------------------------------===//

The min/max instructions aren't exactly a<b?a:b because of NaN and negative zero
behavior. The ARM target has the same kind of min/max instructions and has
implemented optimizations for them; we should do similar optimizations for
WebAssembly.

//===---------------------------------------------------------------------===//

AArch64 runs SeparateConstOffsetFromGEPPass, followed by EarlyCSE and LICM.
Would these be useful to run for WebAssembly too? Also, it has an option to
run SimplifyCFG after running the AtomicExpand pass. Would this be useful for
us too?

//===---------------------------------------------------------------------===//

Register stackification uses the VALUE_STACK physical register to impose
ordering dependencies on instructions with stack operands. This is pessimistic;
we should consider alternate ways to model stack dependencies.

//===---------------------------------------------------------------------===//

Lots of things could be done in WebAssemblyTargetTransformInfo.cpp. Similarly,
there are numerous optimization-related hooks that can be overridden in
WebAssemblyTargetLowering.

//===---------------------------------------------------------------------===//

Instead of the OptimizeReturned pass, which should consider preserving the
"returned" attribute through to MachineInstrs and extending the StoreResults
pass to do this optimization on calls too. That would also let the
WebAssemblyPeephole pass clean up dead defs for such calls, as it does for
stores.

//===---------------------------------------------------------------------===//

Consider implementing optimizeSelect, optimizeCompareInstr, optimizeCondBranch,
optimizeLoadInstr, and/or getMachineCombinerPatterns.

//===---------------------------------------------------------------------===//

Find a clean way to fix the problem which leads to the Shrink Wrapping pass
being run after the WebAssembly PEI pass.

//===---------------------------------------------------------------------===//

When setting multiple local variables to the same constant, we currently get
code like this:

    i32.const   $4=, 0
    i32.const   $3=, 0

It could be done with a smaller encoding like this:

    i32.const   $push5=, 0
    tee_local   $push6=, $4=, $pop5
    copy_local  $3=, $pop6

//===---------------------------------------------------------------------===//

WebAssembly registers are implicitly initialized to zero. Explicit zeroing is
therefore often redundant and could be optimized away.

//===---------------------------------------------------------------------===//

Small indices may use smaller encodings than large indices.
WebAssemblyRegColoring and/or WebAssemblyRegRenumbering should sort registers
according to their usage frequency to maximize the usage of smaller encodings.

//===---------------------------------------------------------------------===//

Many cases of irreducible control flow could be transformed more optimally
than via the transform in WebAssemblyFixIrreducibleControlFlow.cpp.

It may also be worthwhile to do transforms before register coloring,
particularly when duplicating code, to allow register coloring to be aware of
the duplication.

//===---------------------------------------------------------------------===//

WebAssemblyRegStackify could use AliasAnalysis to reorder loads and stores more
aggressively.

//===---------------------------------------------------------------------===//

WebAssemblyRegStackify is currently a greedy algorithm. This means that, for
example, a binary operator will stackify with its user before its operands.
However, if moving the binary operator to its user moves it to a place where
its operands can't be moved to, it would be better to leave it in place, or
perhaps move it up, so that it can stackify its operands. A binary operator
has two operands and one result, so in such cases there could be a net win by
prefering the operands.

//===---------------------------------------------------------------------===//

Instruction ordering has a significant influence on register stackification and
coloring. Consider experimenting with the MachineScheduler (enable via
enableMachineScheduler) and determine if it can be configured to schedule
instructions advantageously for this purpose.

//===---------------------------------------------------------------------===//

WebAssembly is now officially a stack machine, rather than an AST, and this
comes with additional opportunities for WebAssemblyRegStackify. Specifically,
the stack doesn't need to be empty after an instruction with no return values.
WebAssemblyRegStackify could be extended, or possibly rewritten, to take
advantage of the new opportunities.

//===---------------------------------------------------------------------===//