Alex Zinenko 87c5145a5d Perform the MemRef layout map dimensionality check in the Parser. ... This check was being performed in AllocOp::verify. However it is not specific to AllocOp and should apply to all MemRef type declarations. At the same time, the unique *Type factory functions in MLIRContext do not have access to location information necessary to properly emit diagnostics. Emit the error in Parser where the location information is available. Keep the error emission in AllocOp for the cases of programmatically-constructed, e.g. through Builders, IR with a note. Once we decided on the diagnostic infrastructure in type construction system, the type-related checks should be removed from specific Ops. Correct several parser test cases that have been using affine maps of mismatching dimensionality. This CL prepares for an upcoming change that will drop trivial identity affine map compositions during MemRefType construction. In that case, the dimensionality mismatch error must be emitted before dropping the identity map, i.e. during the type construction at the latest and before "verify" being called. PiperOrigin-RevId: 218844127		2019-03-29 13:41:33 -07:00
mlir	Perform the MemRef layout map dimensionality check in the Parser.	2019-03-29 13:41:33 -07:00