maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/llvm/test/ThinLTO/X86/Inputs
History
Teresa Johnson c27ab339ad Restore "[ThinLTO] Avoid temporaries when loading global decl attachment metadata" 
This restores commit ab1b4810b5 which was
reverted in 01b9deba76, with a fix for the
issue it caused. We should use a temporary BitstreamCursor when
loading the global decl attachment records so that the abbrev ids held
in the lazy loading IndexCursor are not clobbered. Enhanced the test so
that the issue is exposed there.

Original description:

When performing ThinLTO importing, the metadata loader attempts to lazy
load, by building an index. However, module level global decl attachment
metadata was being parsed early while building the index, since the
associated (module level) global values aren't materialized on demand.
This results in the creation of forward reference temporary metadatas,
which are expensive.

Normally, these module level global values don't have much attached
metadata. However, in the case of -fwhole-program-vtables (e.g. for
whole program devirtualization), the vtables may have many attached type
metadatas. This was resulting in very slow performance when performing
ThinLTO importing with the default lazy loading.

This patch restructures the handling of these global decl attachment
records, delaying their parsing until after the lazy loading index has
been built. Then the parser can use the interface that loads from the
index, which resolves forward references immediately instead of creating
expensive temporaries.

For one ThinLTO backend that imports from modules containing huge
numbers of vtables and associated types, I measured the following
compile times for the metadata materialization during function
importing, rounded to nearest second:

No -fwhole-program-vtables:
  Lazy loading on (head):  1s
  Lazy loading off (head): 3s
  Lazy loading on (patch): 1s

With -fwhole-program-vtables:
  Lazy loading on (head):  440s
  Lazy loading off (head): 4s
  Lazy loading on (patch): 2s

Differential Revision: https://reviews.llvm.org/D87970
 		2020-10-12 10:11:56 -07:00
..
alias_import.ll [ThinLTO] Use original alias visibility when importing 2019-05-29 16:50:46 +00:00
alias_internal.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
alias_resolution.ll
…
autoupgrade.bc
…
cache-icall.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
cache-import-lists1.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
cache-import-lists2.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
cache-typeid-resolutions-import.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
cache-typeid-resolutions1.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
cache-typeid-resolutions2.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
cache-typeid-resolutions3.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
cache.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
callees-metadata.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
cfi-distributed.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
cfi-icall-only-bazqux.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
cfi-unsat.ll Restore "[WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP" 2020-07-14 12:16:57 -07:00
crash_debuginfo.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
deadstrip.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
debuginfo-compositetype-import.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
debuginfo-cu-import.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
devirt2.ll Restore "[ThinLTO] Avoid temporaries when loading global decl attachment metadata" 2020-10-12 10:11:56 -07:00
devirt_alias.ll [ThinLTO/WPD] Fix index-based WPD for alias vtables 2020-01-13 13:38:26 -08:00
devirt_available_externally.ll [ThinLTO/WPD] Fix index-based WPD for available_externally vtables 2019-10-30 17:59:08 -07:00
devirt_external_comdat_same_guid.ll [ThinLTO/WPD] Remove an overly-aggressive assert 2020-01-14 10:57:14 -08:00
devirt_local_same_guid.ll [ThinLTO/WPD] Fix index-based WPD for available_externally vtables 2019-10-30 17:59:08 -07:00
devirt_promote.ll [ThinLTO/WPD] Ensure devirtualized targets use promoted symbol when necessary 2019-10-02 16:36:59 +00:00
devirt_single_hybrid_bar.ll [ThinLTO] Import virtual method with single implementation in hybrid mode 2019-10-17 07:46:18 +00:00
devirt_single_hybrid_foo.ll [ThinLTO] Import virtual method with single implementation in hybrid mode 2019-10-17 07:46:18 +00:00
diagnostic-handler-remarks.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
dicompositetype-unique-alias.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
dicompositetype-unique.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
dicompositetype-unique2.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
distributed_import.ll
…
distributed_indexes.ll
…
dot-dumper.ll [ThinLTO] Always import constants 2020-01-15 19:29:01 +03:00
dot-dumper2.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
drop-debug-info.bc
…
drop-debug-info.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
dsolocal_dllimport.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
emit_imports.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
emit_imports2.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
empty.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
empty_module_with_cache.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
export.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
funcimport-debug.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
funcimport-tbaa.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
funcimport.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
funcimport2.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
funcimport_alwaysinline.ll ThinLTO : Import always_inline functions irrespective of the threshold 2019-11-08 17:02:01 -08:00
function_entry_count.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
globals-import-blockaddr.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
globals-import-cf-baz.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
globals-import.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
guid_collision.ll Recommit "[ThinLTO] Handle GUID collision in import global processing"" 2019-11-01 13:57:01 -07:00
import-constant.ll [ThinLTO] Always import constants 2020-01-15 19:29:01 +03:00
import-metadata.ll [ThinLTO] Fix a metadata lost issue with DICompileUnit import. 2020-09-02 14:40:41 -07:00
import-ro-constant-bar.ll [ThinLTO] Always import constants 2020-01-15 19:29:01 +03:00
import-ro-constant-foo.ll [ThinLTO] Always import constants 2020-01-15 19:29:01 +03:00
import_opaque_type.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
index-const-prop-alias.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
index-const-prop-cache-foo.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
index-const-prop-cache-test1.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
index-const-prop-cache-test2.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
index-const-prop-comdat.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
index-const-prop-define-g.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
index-const-prop-full-lto.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
index-const-prop-gvref.ll [ThinLTO] Drop dso_local if a GlobalVariable satisfies isDeclarationForLinker() 2020-04-07 15:46:01 -07:00
index-const-prop-linkage.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
index-const-prop.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
internalize.ll [ThinLTO] Fix handling of weak interposable symbols 2019-08-23 15:18:58 +00:00
lazyload_metadata.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
linkonce_aliasee_ref_import.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
linkonce_odr_unnamed_addr.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
linkonce_resolution_comdat.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
llvm.used.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
local_name_conflict1.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
local_name_conflict2.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
local_name_conflict_var1.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
local_name_conflict_var2.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
merge-triple.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
module_asm.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
module_asm2.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
noinline.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
personality-local.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
personality.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
pr35472.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
reference_non_importable.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
referenced_by_constant.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
section.ll
…
select_right_alias_definition1.ll
…
select_right_alias_definition2.ll
…
strong_non_prevailing.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
thinlto-internalize-doublepromoted.ll [ThinLTO] Handle variable with twice promoted name (Rust) 2020-01-14 10:54:03 -08:00
thinlto-internalize-used2.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
weak_resolution.ll Reland "Change the X86 datalayout to add three address spaces 2019-09-10 23:15:38 +00:00
writeonly-with-refs.ll [ThinLTO] Fix bug when importing writeonly variables 2019-11-08 20:50:34 +03:00