forked from OSchip/llvm-project
78 lines
2.9 KiB
C++
78 lines
2.9 KiB
C++
//===--- BoolPointerImplicitConversionCheck.cpp - clang-tidy --------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "BoolPointerImplicitConversionCheck.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang {
|
|
namespace {
|
|
|
|
AST_MATCHER(CastExpr, isPointerToBoolean) {
|
|
return Node.getCastKind() == CK_PointerToBoolean;
|
|
}
|
|
AST_MATCHER(QualType, isBoolean) { return Node->isBooleanType(); }
|
|
|
|
} // namespace
|
|
|
|
namespace tidy {
|
|
namespace misc {
|
|
|
|
void BoolPointerImplicitConversionCheck::registerMatchers(MatchFinder *Finder) {
|
|
// Look for ifs that have an implicit bool* to bool conversion in the
|
|
// condition. Filter negations.
|
|
Finder->addMatcher(
|
|
ifStmt(hasCondition(findAll(implicitCastExpr(
|
|
allOf(unless(hasParent(unaryOperator(hasOperatorName("!")))),
|
|
hasSourceExpression(expr(
|
|
hasType(pointerType(pointee(isBoolean()))),
|
|
ignoringParenImpCasts(declRefExpr().bind("expr")))),
|
|
isPointerToBoolean())))),
|
|
unless(isInTemplateInstantiation())).bind("if"),
|
|
this);
|
|
}
|
|
|
|
void BoolPointerImplicitConversionCheck::check(
|
|
const MatchFinder::MatchResult &Result) {
|
|
auto *If = Result.Nodes.getStmtAs<IfStmt>("if");
|
|
auto *Var = Result.Nodes.getStmtAs<DeclRefExpr>("expr");
|
|
|
|
// Ignore macros.
|
|
if (Var->getLocStart().isMacroID())
|
|
return;
|
|
|
|
// Only allow variable accesses for now, no function calls or member exprs.
|
|
// Check that we don't dereference the variable anywhere within the if. This
|
|
// avoids false positives for checks of the pointer for nullptr before it is
|
|
// dereferenced. If there is a dereferencing operator on this variable don't
|
|
// emit a diagnostic. Also ignore array subscripts.
|
|
const Decl *D = Var->getDecl();
|
|
auto DeclRef = ignoringParenImpCasts(declRefExpr(to(equalsNode(D))));
|
|
if (!match(findAll(
|
|
unaryOperator(hasOperatorName("*"), hasUnaryOperand(DeclRef))),
|
|
*If, *Result.Context).empty() ||
|
|
!match(findAll(arraySubscriptExpr(hasBase(DeclRef))), *If,
|
|
*Result.Context).empty() ||
|
|
// FIXME: We should still warn if the paremater is implicitly converted to
|
|
// bool.
|
|
!match(findAll(callExpr(hasAnyArgument(DeclRef))), *If, *Result.Context)
|
|
.empty() ||
|
|
!match(findAll(cxxDeleteExpr(has(expr(DeclRef)))), *If, *Result.Context)
|
|
.empty())
|
|
return;
|
|
|
|
diag(Var->getLocStart(), "dubious check of 'bool *' against 'nullptr', did "
|
|
"you mean to dereference it?")
|
|
<< FixItHint::CreateInsertion(Var->getLocStart(), "*");
|
|
}
|
|
|
|
} // namespace misc
|
|
} // namespace tidy
|
|
} // namespace clang
|