forked from OSchip/llvm-project
967e7966fc
Summary: Adding part of the changes in D30369 (needed to make progress): Current patch updates AliasAnalysis and MemoryLocation, but does _not_ clean up MemorySSA. Original summary from D30369, by dberlin: Currently, we have instructions which affect memory but have no memory location. If you call, for example, MemoryLocation::get on a fence, it asserts. This means things specifically have to avoid that. It also means we end up with a copy of each API, one taking a memory location, one not. This starts to fix that. We add MemoryLocation::getOrNone as a new call, and reimplement the old asserting version in terms of it. We make MemoryLocation optional in the (Instruction, MemoryLocation) version of getModRefInfo, and kill the old one argument version in favor of passing None (it had one caller). Now both can handle fences because you can just use MemoryLocation::getOrNone on an instruction and it will return a correct answer. We use all this to clean up part of MemorySSA that had to handle this difference. Note that literally every actual getModRefInfo interface we have could be made private and replaced with: getModRefInfo(Instruction, Optional<MemoryLocation>) and getModRefInfo(Instruction, Optional<MemoryLocation>, Instruction, Optional<MemoryLocation>) and delegating to the right ones, if we wanted to. I have not attempted to do this yet. Reviewers: dberlin, davide, dblaikie Subscribers: sanjoy, hfinkel, chandlerc, llvm-commits Differential Revision: https://reviews.llvm.org/D35441 llvm-svn: 309641 |
||
|---|---|---|
| .. | ||
| AliasAnalysisTest.cpp | ||
| AliasSetTrackerTest.cpp | ||
| BlockFrequencyInfoTest.cpp | ||
| BranchProbabilityInfoTest.cpp | ||
| CFGTest.cpp | ||
| CGSCCPassManagerTest.cpp | ||
| CMakeLists.txt | ||
| CallGraphTest.cpp | ||
| GlobalsModRefTest.cpp | ||
| LazyCallGraphTest.cpp | ||
| LoopInfoTest.cpp | ||
| MemoryBuiltinsTest.cpp | ||
| MemorySSA.cpp | ||
| OrderedBasicBlockTest.cpp | ||
| ProfileSummaryInfoTest.cpp | ||
| ScalarEvolutionTest.cpp | ||
| TBAATest.cpp | ||
| TargetLibraryInfoTest.cpp | ||
| UnrollAnalyzer.cpp | ||
| ValueTrackingTest.cpp | ||