llvm-project/lldb/source/Core
Emre Kultursay 865996ddf6 [lldb] Remove m_last_file_sp from SourceManager
Summary:
...and replace it with m_last_file_spec instead.

When Source Cache is enabled, the value stored in m_last_file_sp is
already in the Source Cache, and caching it again in SourceManager
brings no extra benefit. All we need is to "remember" the last used
file, and FileSpec can serve the same purpose.

When Source Cache is disabled, the user explicitly requested no caching
of source files, and therefore, m_last_file_sp should NOT be used.

Bug: llvm.org/PR45310

Depends on D76805.

Reviewers: labath, jingham

Reviewed By: jingham

Subscribers: labath, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D76806
2020-04-20 16:27:19 +02:00
..
Address.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
AddressRange.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
AddressResolver.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
AddressResolverFileLine.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
AddressResolverName.cpp [lldb][NFC] Make all CompilerDeclContext parameters references instead of pointers 2020-02-18 08:58:36 +01:00
CMakeLists.txt [lldb] Increase LINK_INTERFACE_MULTIPLICITY for Debug builds 2020-02-04 14:30:27 +01:00
Communication.cpp [lldb] Add parts accidentally left out of 769d704: Recommit "[lldb/Core] Fix a race in the Communication class" 2020-04-09 14:45:23 +02:00
CoreProperties.td [lldb] Add new LLDB setting: use-source-cache 2020-04-20 16:24:25 +02:00
Debugger.cpp [lldb] Add new LLDB setting: use-source-cache 2020-04-20 16:24:25 +02:00
Disassembler.cpp [lldb] Reduce duplication in the Disassembler class 2020-03-09 13:41:43 +01:00
DumpDataExtractor.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
DumpRegisterValue.cpp Make llvm::StringRef to std::string conversions explicit. 2020-01-28 23:25:25 +01:00
DynamicLoader.cpp [lldb][NFC] Remove several inefficient ConstString -> const char * -> StringRef conversions 2020-02-11 09:14:41 +01:00
EmulateInstruction.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
FileLineResolver.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
FileSpecList.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
FormatEntity.cpp [lldb] NFC: Fix trivial typo in comments, documents, and messages 2020-04-07 01:06:16 +09:00
Highlighter.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
IOHandler.cpp [lldb] Make sure we don't drop asynchronous output when sourcing files 2020-03-03 11:18:41 +01:00
IOHandlerCursesGUI.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
Mangled.cpp [lldb][NFC] Remove several inefficient ConstString -> const char * -> StringRef conversions 2020-02-11 09:14:41 +01:00
Module.cpp Remap the target (Xcode) SDK directory to the host SDK directory. 2020-04-06 15:51:30 -07:00
ModuleChild.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
ModuleList.cpp [lldb][NFC] Make all CompilerDeclContext parameters references instead of pointers 2020-02-18 08:58:36 +01:00
Opcode.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
PluginManager.cpp [lldb/Core] Remove locking in the PluginManager 2020-02-19 10:04:05 -08:00
RichManglingContext.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
SearchFilter.cpp [lldb][nfc] remove overriden funcs with default impl 2020-04-06 10:05:59 -04:00
Section.cpp [lldb] Remove some #ifdef LLDB_CONFIGURATION_DEBUG around asserts 2020-03-06 11:21:00 -08:00
SourceManager.cpp [lldb] Remove m_last_file_sp from SourceManager 2020-04-20 16:27:19 +02:00
StreamAsynchronousIO.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
StreamFile.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
UserSettingsController.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
Value.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
ValueObject.cpp Data formatters: fix detection of C strings 2020-03-24 14:25:59 +01:00
ValueObjectCast.cpp [lldb] Delete commented-out code 2020-02-04 15:33:06 -08:00
ValueObjectChild.cpp [lldb][NFC] Remove GetConstTypeName and GetConstQualifiedTypeName from CompilerType 2020-02-12 09:49:39 +01:00
ValueObjectConstResult.cpp [lldb][NFC] Remove GetConstTypeName and GetConstQualifiedTypeName from CompilerType 2020-02-12 09:49:39 +01:00
ValueObjectConstResultCast.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
ValueObjectConstResultChild.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
ValueObjectConstResultImpl.cpp [lldb] Delete the SharingPtr class 2020-02-11 13:23:18 +01:00
ValueObjectDynamicValue.cpp [lldb] Remove DataExtractor::GetPointer 2020-02-18 10:38:41 +01:00
ValueObjectList.cpp [lldb] Delete the SharingPtr class 2020-02-11 13:23:18 +01:00
ValueObjectMemory.cpp [lldb][NFC] Remove GetConstTypeName and GetConstQualifiedTypeName from CompilerType 2020-02-12 09:49:39 +01:00
ValueObjectRegister.cpp [lldb][NFC] Remove GetConstTypeName and GetConstQualifiedTypeName from CompilerType 2020-02-12 09:49:39 +01:00
ValueObjectSyntheticFilter.cpp [lldb] Delete the SharingPtr class 2020-02-11 13:23:18 +01:00
ValueObjectVariable.cpp [lldb] Delete the SharingPtr class 2020-02-11 13:23:18 +01:00