forked from OSchip/llvm-project
2df59c5068
Summary: Freestanding is *weird*. The standard allows it to differ in a bunch of odd manners from regular C++, and the committee would like to improve that situation. I'd like to make libc++ behave better with what freestanding should be, so that it can be a tool we use in improving the standard. To do that we need to try stuff out, both with "freestanding the language mode" and "freestanding the library subset". Let's start with the super basic: run the libc++ tests in freestanding, using clang as the compiler, and see what works. The easiest hack to do this: In utils/libcxx/test/config.py add: self.cxx.compile_flags += ['-ffreestanding'] Run the tests and they all fail. Why? Because in freestanding `main` isn't special. This "not special" property has two effects: main doesn't get mangled, and main isn't allowed to omit its `return` statement. The first means main gets mangled and the linker can't create a valid executable for us to test. The second means we spew out warnings (ew) and the compiler doesn't insert the `return` we omitted, and main just falls of the end and does whatever undefined behavior (if you're luck, ud2 leading to non-zero return code). Let's start my work with the basics. This patch changes all libc++ tests to declare `main` as `int main(int, char**` so it mangles consistently (enabling us to declare another `extern "C"` main for freestanding which calls the mangled one), and adds `return 0;` to all places where it was missing. This touches 6124 files, and I apologize. The former was done with The Magic Of Sed. The later was done with a (not quite correct but decent) clang tool: https://gist.github.com/jfbastien/793819ff360baa845483dde81170feed This works for most tests, though I did have to adjust a few places when e.g. the test runs with `-x c`, macros are used for main (such as for the filesystem tests), etc. Once this is in we can create a freestanding bot which will prevent further regressions. After that, we can start the real work of supporting C++ freestanding fairly well in libc++. <rdar://problem/47754795> Reviewers: ldionne, mclow.lists, EricWF Subscribers: christof, jkorous, dexonsmith, arphaman, miyuki, libcxx-commits Differential Revision: https://reviews.llvm.org/D57624 llvm-svn: 353086 |
||
|---|---|---|
| .. | ||
| test.support | ||
| test.workarounds | ||
| Counter.h | ||
| DefaultOnly.h | ||
| MoveOnly.h | ||
| allocators.h | ||
| any_helpers.h | ||
| archetypes.hpp | ||
| archetypes.ipp | ||
| asan_testing.h | ||
| assert_checkpoint.h | ||
| charconv_test_helpers.h | ||
| cmpxchg_loop.h | ||
| constexpr_char_traits.hpp | ||
| container_test_types.h | ||
| controlled_allocators.hpp | ||
| coroutine_types.h | ||
| count_new.hpp | ||
| counting_predicates.hpp | ||
| debug_mode_helper.h | ||
| deleter_types.h | ||
| demangle.h | ||
| disable_missing_braces_warning.h | ||
| emplace_constructible.h | ||
| experimental_any_helpers.h | ||
| external_threads.cpp | ||
| filesystem_dynamic_test_helper.py | ||
| filesystem_include.hpp | ||
| filesystem_test_helper.hpp | ||
| format_string.hpp | ||
| hexfloat.h | ||
| is_transparent.h | ||
| min_allocator.h | ||
| msvc_stdlib_force_include.hpp | ||
| nasty_containers.hpp | ||
| nasty_macros.hpp | ||
| nothing_to_do.pass.cpp | ||
| platform_support.h | ||
| poisoned_hash_helper.hpp | ||
| private_constructor.hpp | ||
| propagate_const_helpers.h | ||
| rapid-cxx-test.hpp | ||
| set_windows_crt_report_mode.h | ||
| test_allocator.h | ||
| test_comparisons.h | ||
| test_convertible.hpp | ||
| test_iterators.h | ||
| test_macros.h | ||
| test_memory_resource.hpp | ||
| test_workarounds.h | ||
| tracked_value.h | ||
| truncate_fp.h | ||
| type_id.h | ||
| unique_ptr_test_helper.h | ||
| user_defined_integral.hpp | ||
| uses_alloc_types.hpp | ||
| variant_test_helpers.hpp | ||
| verbose_assert.h | ||