forked from OSchip/llvm-project
78886233b3
New checker called bugprone-not-null-terminated-result. This check finds function calls where it is possible to cause a not null-terminated result. Usually the proper length of a string is strlen(src) + 1 or equal length of this expression, because the null terminator needs an extra space. Without the null terminator it can result in undefined behaviour when the string is read.
The following function calls are checked:
memcpy, wmemcpy, memcpy_s, wmemcpy_s, memchr, wmemchr, memmove, wmemmove, memmove_s, wmemmove_s, memset, wmemset, strerror_s, strncmp, wcsncmp, strxfrm, wcsxfrm
The following is a real-world example where the programmer forgot to increase the passed third argument, which is size_t length. That is why the length of the allocated memory is problematic too.
static char *StringCpy(const std::string &str) {
char *result = reinterpret_cast<char *>(malloc(str.size()));
memcpy(result, str.data(), str.size());
return result;
}
After running the tool fix-it rewrites all the necessary code according to the given options. If it is necessary, the buffer size will be increased to hold the null terminator.
static char *StringCpy(const std::string &str) {
char *result = reinterpret_cast<char *>(malloc(str.size() + 1));
strcpy(result, str.data());
return result;
}
Patch by Charusso.
Differential ID: https://reviews.llvm.org/D45050
llvm-svn: 344374
|
||
|---|---|---|
| .. | ||
| abseil | ||
| android | ||
| boost | ||
| bugprone | ||
| cert | ||
| cppcoreguidelines | ||
| fuchsia | ||
| hicpp | ||
| llvm | ||
| misc | ||
| modernize | ||
| mpi | ||
| objc | ||
| performance | ||
| plugin | ||
| portability | ||
| readability | ||
| tool | ||
| utils | ||
| zircon | ||
| CMakeLists.txt | ||
| ClangTidy.cpp | ||
| ClangTidy.h | ||
| ClangTidyDiagnosticConsumer.cpp | ||
| ClangTidyDiagnosticConsumer.h | ||
| ClangTidyModule.cpp | ||
| ClangTidyModule.h | ||
| ClangTidyModuleRegistry.h | ||
| ClangTidyOptions.cpp | ||
| ClangTidyOptions.h | ||
| ClangTidyProfiling.cpp | ||
| ClangTidyProfiling.h | ||
| add_new_check.py | ||
| rename_check.py | ||