forked from OSchip/llvm-project
fcfa7c5f92
Summary: The original assumption for the insertDef method was that it would not materialize Defs out of no-where, hence it will not insert phis needed after inserting a Def. However, when cloning an instruction (use case used in LICM), we do materialize Defs "out of no-where". If the block receiving a Def has at least one other Def, then no processing is needed. If the block just received its first Def, we must check where Phi placement is needed. The only new usage of insertDef is in LICM, hence the trigger for the bug. But the original goal of the method also fails to apply for the move() method. If we move a Def from the entry point of a diamond to either the left or right blocks, then the merge block must add a phi. While this usecase does not currently occur, or may be viewed as an incorrect transformation, MSSA must behave corectly given the scenario. Resolves PR40749 and PR40754. Reviewers: george.burgess.iv Subscribers: sanjoy, jlebar, Prazek, jdoerfert, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D58652 llvm-svn: 355040 |
||
|---|---|---|
| .. | ||
| assume.ll | ||
| atomic-clobber.ll | ||
| basicaa-memcpy.ll | ||
| constant-memory.ll | ||
| cyclicphi.ll | ||
| forward-unreachable.ll | ||
| function-clobber.ll | ||
| function-mem-attrs.ll | ||
| invariant-groups.ll | ||
| lifetime-simple.ll | ||
| load-invariant.ll | ||
| many-dom-backedge.ll | ||
| many-doms.ll | ||
| multi-edges.ll | ||
| multiple-backedges-hal.ll | ||
| multiple-locations.ll | ||
| no-disconnected.ll | ||
| optimize-use.ll | ||
| phi-translation.ll | ||
| pr28880.ll | ||
| pr36883.ll | ||
| pr39197.ll | ||
| pr40037.ll | ||
| pr40038.ll | ||
| pr40509.ll | ||
| pr40749.ll | ||
| pr40754.ll | ||
| ptr-const-mem.ll | ||
| volatile-clobber.ll | ||