forked from OSchip/llvm-project
3348b841d3
By default `llvm::seq` would happily iterate over enums, which may be unsafe if the enum values are not continuous. This patch disable enum iteration with `llvm::seq` and `llvm::seq_inclusive` and adds two new functions: `enum_seq` and `enum_seq_inclusive`. To make sure enum iteration is safe, we require users to declare their enum types as iterable by specializing `enum_iteration_traits<SomeEnum>`. Because it's not always possible to add these traits next to enum definition (e.g., for enums defined in external libraries), we provide an escape hatch to allow iteration on per-callsite basis by passing `force_iteration_on_noniterable_enum`. The main benefit of this approach is that these global declarations via traits can appear just next to enum definitions, making easy to spot when enums are miss-labeled, e.g., after introducing new enum values, whereas `force_iteration_on_noniterable_enum` should stand out and be easy to grep for. This emerged from a discussion with gchatelet@ about reusing llvm's `Sequence.h` in lieu of https://github.com/GPUOpen-Drivers/llpc/blob/dev/lgc/interface/lgc/EnumIterator.h. Reviewed By: dblaikie, gchatelet, aaron.ballman Differential Revision: https://reviews.llvm.org/D107378 |
||
|---|---|---|
| .. | ||
| AbstractCallSiteTest.cpp | ||
| AsmWriterTest.cpp | ||
| AttributesTest.cpp | ||
| BasicBlockTest.cpp | ||
| CFGBuilder.cpp | ||
| CFGBuilder.h | ||
| CMakeLists.txt | ||
| ConstantRangeTest.cpp | ||
| ConstantsTest.cpp | ||
| DataLayoutTest.cpp | ||
| DebugInfoTest.cpp | ||
| DebugTypeODRUniquingTest.cpp | ||
| DemandedBitsTest.cpp | ||
| DominatorTreeBatchUpdatesTest.cpp | ||
| DominatorTreeTest.cpp | ||
| FunctionTest.cpp | ||
| IRBuilderTest.cpp | ||
| InstructionsTest.cpp | ||
| IntrinsicsTest.cpp | ||
| LegacyPassManagerTest.cpp | ||
| MDBuilderTest.cpp | ||
| ManglerTest.cpp | ||
| MetadataTest.cpp | ||
| ModuleTest.cpp | ||
| PassBuilderCallbacksTest.cpp | ||
| PassManagerTest.cpp | ||
| PatternMatch.cpp | ||
| TimePassesTest.cpp | ||
| TypesTest.cpp | ||
| UseTest.cpp | ||
| UserTest.cpp | ||
| VPIntrinsicTest.cpp | ||
| ValueHandleTest.cpp | ||
| ValueMapTest.cpp | ||
| ValueTest.cpp | ||
| VectorTypesTest.cpp | ||
| VerifierTest.cpp | ||