forked from OSchip/llvm-project
d806af3499
We currently use target_link_libraries without an explicit scope specifier (INTERFACE, PRIVATE or PUBLIC) when linking executables. Dependencies added in this way apply to both the target and its dependencies, i.e. they become part of the executable's link interface and are transitive. Transitive dependencies generally don't make sense for executables, since you wouldn't normally be linking against an executable. This also causes issues for generating install export files when using LLVM_DISTRIBUTION_COMPONENTS. For example, clang has a lot of LLVM library dependencies, which are currently added as interface dependencies. If clang is in the distribution components but the LLVM libraries it depends on aren't (which is a perfectly legitimate use case if the LLVM libraries are being built static and there are therefore no run-time dependencies on them), CMake will complain about the LLVM libraries not being in export set when attempting to generate the install export file for clang. This is reasonable behavior on CMake's part, and the right thing is for LLVM's build system to explicitly use PRIVATE dependencies for executables. Unfortunately, CMake doesn't allow you to mix and match the keyword and non-keyword target_link_libraries signatures for a single target; i.e., if a single call to target_link_libraries for a particular target uses one of the INTERFACE, PRIVATE, or PUBLIC keywords, all other calls must also be updated to use those keywords. This means we must do this change in a single shot. I also fully expect to have missed some instances; I tested by enabling all the projects in the monorepo (except dragonegg), and configuring both with and without shared libraries, on both Darwin and Linux, but I'm planning to rely on the buildbots for other configurations (since it should be pretty easy to fix those). Even after this change, we still have a lot of target_link_libraries calls that don't specify a scope keyword, mostly for shared libraries. I'm thinking about addressing those in a follow-up, but that's a separate change IMO. Differential Revision: https://reviews.llvm.org/D40823 llvm-svn: 319840 |
||
|---|---|---|
| .. | ||
| android | ||
| boost | ||
| bugprone | ||
| cert | ||
| cppcoreguidelines | ||
| fuchsia | ||
| hicpp | ||
| llvm | ||
| misc | ||
| modernize | ||
| mpi | ||
| objc | ||
| performance | ||
| plugin | ||
| readability | ||
| tool | ||
| utils | ||
| CMakeLists.txt | ||
| ClangTidy.cpp | ||
| ClangTidy.h | ||
| ClangTidyDiagnosticConsumer.cpp | ||
| ClangTidyDiagnosticConsumer.h | ||
| ClangTidyModule.cpp | ||
| ClangTidyModule.h | ||
| ClangTidyModuleRegistry.h | ||
| ClangTidyOptions.cpp | ||
| ClangTidyOptions.h | ||
| add_new_check.py | ||
| rename_check.py | ||