llvm-project/clang
Brian Gesiak 3aba9fd64f [SemaCXX] Param diagnostic matches overload logic
Summary:
Given the following test program:

```
class C {
public:
  int A(int a, int& b);
};

int C::A(const int a, int b) {
  return a * b;
}
```

Clang would produce an error message that correctly diagnosed the
redeclaration of `C::A` to not match the original declaration (the
parameters to the two declarations do not match -- the original takes an
`int &` as its 2nd parameter, but the redeclaration takes an `int`). However,
it also produced a note diagnostic that inaccurately pointed to the
first parameter, claiming that `const int` in the redeclaration did not
match the unqualified `int` in the original. The diagnostic is
misleading because it has nothing to do with why the program does not
compile.

The logic for checking for a function overload, in
`Sema::FunctionParamTypesAreEqual`, discards cv-qualifiers before
checking whether the types are equal. Do the same when producing the
overload diagnostic.

Reviewers: rsmith

Reviewed By: rsmith

Subscribers: cpplearner, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D57032

llvm-svn: 352831
2019-02-01 03:30:29 +00:00
..
INPUTS
bindings Fix python3 compability issue in clang binding 2019-01-24 10:34:44 +00:00
cmake [CMake][Fuchsia] Re-enable iOS runtimes for Fuchsia standard 2019-01-30 02:06:06 +00:00
docs [sanitizer-coverage] prune trace-cmp instrumentation for CMP isntructions that feed into the backedge branch. Instrumenting these CMP instructions is almost always useless (and harmful) for fuzzing 2019-01-31 23:43:00 +00:00
examples Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
include Make clang/test/Index/pch-from-libclang.c pass in more places 2019-01-31 22:15:32 +00:00
lib [SemaCXX] Param diagnostic matches overload logic 2019-02-01 03:30:29 +00:00
runtime Fix check-hwasan with LLVM_BUILD_EXTERNAL_COMPILER_RT=ON 2019-01-03 22:50:45 +00:00
test [SemaCXX] Param diagnostic matches overload logic 2019-02-01 03:30:29 +00:00
tools Make clang/test/Index/pch-from-libclang.c pass in more places 2019-01-31 22:15:32 +00:00
unittests [CUDA] add support for the new kernel launch API in CUDA-9.2+. 2019-01-31 21:34:03 +00:00
utils [ASTDump] Rename methods which are conceptually Visits 2019-01-30 19:49:49 +00:00
www Adjust documentation for git migration. 2019-01-29 16:37:27 +00:00
.arcconfig
.clang-format
.clang-tidy
.gitignore Adjust documentation for git migration. 2019-01-29 16:37:27 +00:00
CMakeLists.txt inhereit LLVM_ENABLE_LIBXML2 2018-11-29 14:57:14 +00:00
CODE_OWNERS.TXT Add myself as code owner for OpenBSD driver 2018-11-30 21:42:34 +00:00
INSTALL.txt
LICENSE.TXT Fix typos throughout the license files that somehow I and my reviewers 2019-01-21 09:52:34 +00:00
ModuleInfo.txt
NOTES.txt PTH-- Remove feature entirely- 2018-12-04 14:34:09 +00:00
README.txt

README.txt

//===----------------------------------------------------------------------===//
// C Language Family Front-end
//===----------------------------------------------------------------------===//

Welcome to Clang.  This is a compiler front-end for the C family of languages
(C, C++, Objective-C, and Objective-C++) which is built as part of the LLVM
compiler infrastructure project.

Unlike many other compiler frontends, Clang is useful for a number of things
beyond just compiling code: we intend for Clang to be host to a number of
different source-level tools.  One example of this is the Clang Static Analyzer.

If you're interested in more (including how to build Clang) it is best to read
the relevant web sites.  Here are some pointers:

Information on Clang:             http://clang.llvm.org/
Building and using Clang:         http://clang.llvm.org/get_started.html
Clang Static Analyzer:            http://clang-analyzer.llvm.org/
Information on the LLVM project:  http://llvm.org/

If you have questions or comments about Clang, a great place to discuss them is
on the Clang development mailing list:
  http://lists.llvm.org/mailman/listinfo/cfe-dev

If you find a bug in Clang, please file it in the LLVM bug tracker:
  http://llvm.org/bugs/