llvm-project/lldb/source
Raphael Isemann 50f1985353 [lldb][NFC] Delete the original UserExpression before trying to reparse it with FixIts.
Currently when an expression fails to parse and we have a FixIt, we keep
the failed UserExpression around while trying to parse the expression with
applied fixits. This means that we have this rather confusing control flow:

1. Original expression created and parsing attempted.
2. Expression with applied FixIts is created and parsing attempted.
3. Original expression is destroyed and parser deconstructed.
4. Expression with applied FixIts is destroyed and parser deconstructed.

This patch just deletes the original expression so that step 2 and 3 are
swapped and the whole process looks more like just sequentially parsing two
expressions (which is what we actually do here).

Doesn't fix anything just makes the code less fragile.
2020-03-19 18:10:57 +01:00
..
API [lldb] s/ExecutionContext/Target in Disassembler 2020-03-05 14:46:39 +01:00
Breakpoint [lldb][NFC] Move local variables near to their usage 2020-03-04 16:56:51 +03:00
Commands [lldb/Target] Support more than 2 symbols in StackFrameRecognizer 2020-03-18 14:15:58 +01:00
Core [lldb] Reduce duplication in the Disassembler class 2020-03-09 13:41:43 +01:00
DataFormatters Revert "[lldb] Fix string summary of an empty NSPathStore2" 2020-03-19 13:08:39 +01:00
Expression [lldb][NFC] Delete the original UserExpression before trying to reparse it with FixIts. 2020-03-19 18:10:57 +01:00
Host [Host] Remove some code that's not needed anymore. 2020-03-18 14:44:53 -07:00
Initialization [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
Interpreter [lldb] Update the current execution context at the beginning of tab completions 2020-03-06 10:44:00 -08:00
Plugins Revert "[lldb] Fix string summary of an empty NSPathStore2" 2020-03-19 13:08:39 +01:00
Symbol Add a verification mechanism to CompilerType. 2020-03-11 12:43:32 -07:00
Target [lldb/Target] Support more than 2 symbols in StackFrameRecognizer 2020-03-18 14:15:58 +01:00
Utility [lldb/Reproducers] Intercept the FindProcesses API 2020-03-13 09:31:35 -07:00
CMakeLists.txt Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well. 2020-01-16 19:04:08 -05:00
lldb.cpp [lldb] Fix version string when using LLDB_REVISION but not LLDB_REPOSITORY 2020-02-20 10:07:50 -08:00