llvm-project/lldb
Raphael Isemann 50f1985353 [lldb][NFC] Delete the original UserExpression before trying to reparse it with FixIts.
Currently when an expression fails to parse and we have a FixIt, we keep
the failed UserExpression around while trying to parse the expression with
applied fixits. This means that we have this rather confusing control flow:

1. Original expression created and parsing attempted.
2. Expression with applied FixIts is created and parsing attempted.
3. Original expression is destroyed and parser deconstructed.
4. Expression with applied FixIts is destroyed and parser deconstructed.

This patch just deletes the original expression so that step 2 and 3 are
swapped and the whole process looks more like just sequentially parsing two
expressions (which is what we actually do here).

Doesn't fix anything just makes the code less fragile.
2020-03-19 18:10:57 +01:00
..
bindings [lldb/Bindings] Check that process isn't None before calling is_alive. 2020-03-17 17:06:04 -07:00
cmake [lldb][cmake] Move remove_module_flags macro to AddLLDB.cmake 2020-03-06 17:21:24 -08:00
docs Revert "Revert "[lldb/Docs] Mark both Python 3.6 and 3.8 as supported on Windows"" 2020-03-03 20:43:16 +01:00
examples [lldb] Make gdbremote.py utility py2and3 compatible 2020-02-13 09:18:55 +01:00
include/lldb Revert "[lldb] Fix string summary of an empty NSPathStore2" 2020-03-19 13:08:39 +01:00
packages/Python/lldbsuite [lldb] fix typo in comment for lldbtest.py 2020-03-19 10:08:11 -04:00
resources
scripts [lldb/Scripts] Remove swig_bot_lib/__init__.py 2020-01-16 09:15:41 -08:00
source [lldb][NFC] Delete the original UserExpression before trying to reparse it with FixIts. 2020-03-19 18:10:57 +01:00
test [lldb/testsuite] un-XFail TestInlineStepping.py on linux and windows 2020-03-19 09:24:11 -07:00
third_party/Python/module Increase timeout in pexpect to lower chances of tests failing under ASAN. 2019-10-10 16:16:49 +00:00
tools Update so debugserver can be built on macos again with xcodebuild. 2020-03-18 21:46:20 -07:00
unittests [lldb/PlatformDarwin] Expose current toolchain and CL tools directory 2020-03-18 15:08:24 -07:00
utils [lldb/Utils] Use PYTHON_EXECUTABLE to configure lldb-dotest's shebang 2020-03-15 20:34:17 -07:00
.clang-format
.clang-tidy [lldb] Add .clang-tidy with customization to disable readability-identifier-naming 2020-03-09 12:50:28 -07:00
.gitignore Add .noindex to the gitignore 2019-04-05 17:57:42 +00:00
CMakeLists.txt [lldb/Cmake] Add a CMakeLists.txt to the utils directory... 2020-01-16 22:31:01 -08:00
CODE_OWNERS.txt [lldb][NFC] Cleanup mentions and code related to lldb-mi 2019-07-19 15:55:23 +00:00
LICENSE.TXT Fix typos throughout the license files that somehow I and my reviewers 2019-01-21 09:52:34 +00:00
use_lldb_suite_root.py