forked from OSchip/llvm-project
7acbf00f96
Now we have a list of all commands. This is a good thing in itself, but it also enables us to easily implement typo correction for command names. With this change we have objects that contain information about each command, so it makes sense to resolve command name just once during lexing (currently we store command names as strings and do a linear search every time some property value is needed). Thus comment token and AST nodes were changed to contain a command ID -- index into a tables of builtin and registered commands. Unknown commands are registered during parsing and thus are also uniformly assigned an ID. Using an ID instead of a StringRef is also a nice memory optimization since ID is a small integer that fits into a common bitfield in Comment class. This change implies that to get any information about a command (even a command name) we need a CommandTraits object to resolve the command ID to CommandInfo*. Currently a fresh temporary CommandTraits object is created whenever it is needed since it does not have any state. But with this change it has state -- new commands can be registered, so a CommandTraits object was added to ASTContext. Also, in libclang CXComment has to be expanded to include a CXTranslationUnit so that all functions working on comment AST nodes can get a CommandTraits object. This breaks binary compatibility of CXComment APIs. Now clang_FullComment_getAsXML(CXTranslationUnit TU, CXComment CXC) doesn't need TU parameter anymore, so it was removed. This is a source-incompatible change for this C API. llvm-svn: 163540 |
||
|---|---|---|
| .. | ||
| ABITest | ||
| C++Tests | ||
| CIndex | ||
| OptionalTests | ||
| TableGen | ||
| TestUtils | ||
| VtableTest | ||
| analyzer | ||
| valgrind | ||
| CaptureCmd | ||
| CmpDriver | ||
| FindSpecRefs | ||
| FuzzTest | ||
| SummarizeErrors | ||
| builtin-defines.c | ||
| clang-completion-mode.el | ||
| clangVisualizers.txt | ||
| find-unused-diagnostics.sh | ||
| token-delta.py | ||