forked from OSchip/llvm-project
4e5a59a383
Bug: An assertion fails:
Assertion failed: isa<To>(Val) && "cast<Ty>() argument of incompatible type!",
file C:\Users\<user>\prog\llvm\llvm-git-lld-bug\llvm\include\llvm/Support/Casting.h, line 578
Bug is triggered, if
- a map file is requested with /MAP, and
- Architecture is ARMv7, Thumb, and
- a relative jump (branch instruction) is greater than 16 MiB (2^24)
The reason for the Bug is:
- a Thunk is created for the jump
- a Symbol for the Thunk is created
- of type `DefinedSynthetic`
- in file `Writer.cpp`
- in function `getThunk`
- the Symbol has no name
- when creating the map file, the name of the Symbol is queried
- the function `Symbol::computeName` of the base class `Symbol`
casts the `this` pointer to type `DefinedCOFF` (a derived type),
but the acutal type is `DefinedSynthetic`
- The in the llvm::cast an assertion fails
Changes:
- Modify regression test to trigger this bug
- Give the symbol pointing to the thunk a name, to fix the bug
- Add assertion, that only DefinedCOFF symbols are allowed to have an
empty name, when the constructor of the base class Symbol is executed
Reviewed By: rnk
Differential Revision: https://reviews.llvm.org/D133201
|
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| COFFLinkerContext.cpp | ||
| COFFLinkerContext.h | ||
| CallGraphSort.cpp | ||
| CallGraphSort.h | ||
| Chunks.cpp | ||
| Chunks.h | ||
| Config.h | ||
| DLL.cpp | ||
| DLL.h | ||
| DebugTypes.cpp | ||
| DebugTypes.h | ||
| Driver.cpp | ||
| Driver.h | ||
| DriverUtils.cpp | ||
| ICF.cpp | ||
| ICF.h | ||
| InputFiles.cpp | ||
| InputFiles.h | ||
| LLDMapFile.cpp | ||
| LLDMapFile.h | ||
| LTO.cpp | ||
| LTO.h | ||
| MapFile.cpp | ||
| MapFile.h | ||
| MarkLive.cpp | ||
| MarkLive.h | ||
| MinGW.cpp | ||
| MinGW.h | ||
| Options.td | ||
| PDB.cpp | ||
| PDB.h | ||
| README.md | ||
| SymbolTable.cpp | ||
| SymbolTable.h | ||
| Symbols.cpp | ||
| Symbols.h | ||
| TypeMerger.h | ||
| Writer.cpp | ||
| Writer.h | ||
README.md
See docs/NewLLD.rst